Fix user deletion foreign key constraint issue and add error handling

Author: zee-rgb

app/controllers/users/registrations_controller.rb

@@ -7,13 +7,26 @@ def confirm_delete
 
   # Ensure we redirect to a public page with a clear flash after account deletion
   def destroy
-    resource = resource_class.to_adapter.get!(send(:"current_#{resource_name}").to_key)
+    resource = resource_class.to_adapter.get!(send("current_#{resource_name}").to_key)
 
-    # Destroy user account
-    resource.destroy
+    begin
+      # Destroy user account
+      if resource.destroy
+        # Sign out and set the Devise flash message
+        Devise.sign_out_all_scopes ? sign_out : sign_out(resource_name)
+        redirect_to(home_path, status: :see_other, notice: find_message(:destroyed))
+      else
+        # If resource was not destroyed due to validation errors
+        redirect_to(edit_user_registration_path, alert: resource.errors.full_messages.to_sentence)
+      end
+    rescue => e
+      # Log the error for debugging
+      Rails.logger.error "Failed to delete user account: #{e.message}"
+      Rails.logger.error e.backtrace.join("\n")
 
-    # Sign out and set the Devise flash message
-    Devise.sign_out_all_scopes ? sign_out : sign_out(resource_name)
-    redirect_to(home_path, status: :see_other, notice: find_message(:destroyed))
+      # Redirect with helpful error message
+      redirect_to(edit_user_registration_path,
+                 alert: "Unable to delete account due to a system error. Please try again later or contact support.")
+    end
   end
 end

app/models/user.rb

@@ -5,4 +5,5 @@ class User < ApplicationRecord
          :recoverable, :rememberable, :validatable
 
   has_many :entries, dependent: :destroy
+  has_many :audit_events, dependent: :destroy
 end