Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove URI.encode from v5.+ to support Ruby 3.0 #26

Open
hartsick opened this issue Aug 10, 2023 · 0 comments
Open

Remove URI.encode from v5.+ to support Ruby 3.0 #26

hartsick opened this issue Aug 10, 2023 · 0 comments

Comments

@hartsick
Copy link

hartsick commented Aug 10, 2023

Hi there. Right now the gem release supporting v1.1 of the API (v 5.x) is incompatible with Ruby 3.0, which is the oldest version of Ruby with security updates.

The line causing an issue is here:
https://github.com/zendesk/sunshine-conversations-ruby/blob/5.34.1/lib/smooch-api/configuration.rb#L178, and I assume here, though I haven't received an error from it yet: https://github.com/zendesk/sunshine-conversations-ruby/blob/5.34.1/lib/smooch-api/api_client.rb#L255.

And, as an example, results in a NoMethodError: undefined method 'encode' for URI:Module exception when SmoochApi::ConversationApi.new(<client>).post_message is called.

Could you all replace URI.encode, which has been removed from Ruby in 3.0, and cut a new release? This commit was enough to cover our use case, in case it's useful as reference.

Thanks!

@hartsick hartsick changed the title Remove URI.encode from 5.+ to support Ruby 3.0 Remove URI.encode from v5.+ to support Ruby 3.0 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant