Skip to content

Commit 89c3a45

Browse files
authored
Merge pull request #2883 from zero-to-mastery/maintenance_clarify-contribution-objective
Maintenance: clarify the objective
2 parents 112ae40 + 0a6c465 commit 89c3a45

File tree

2 files changed

+130
-49
lines changed

2 files changed

+130
-49
lines changed

README.md

Lines changed: 130 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -8,118 +8,199 @@
88

99
Welcome to **Animation Nation**, a fun and creative project by the [ZTM Community](https://github.com/zero-to-mastery) as part of **Hacktoberfest**! 🎉
1010

11-
This repository is a space where developers of all levels, especially **beginners**, can contribute, showcase their creativity, and participate in **Hacktoberfest 2024**. Whether you're a seasoned developer or writing your first line of code, we'd love to see your animated artwork using only **HTML** and **CSS**—no JavaScript or images allowed!
12-
13-
## 🚀 Quick Start
14-
15-
1. **Fork the repo** to your GitHub account.
16-
2. **Clone your fork** to your local machine.
17-
3. **Create a branch**, you should not be working in the main/master branch
18-
4. Create a new directory in the Art directory. Naming it <your_github_username>-<your_arts_name>
19-
5. Create your animated HTML and CSS artwork.
20-
6. Pull down recent changes
21-
7. **Submit a pull request (PR)** with your animated artwork
22-
8. **OPTIONAL** [Tweet about making your first Hacktoberfest pull request](https://ctt.ac/36L1C), and you're done! 🎉
23-
24-
#### 📌 _Don't worry if it's your first time contributing—below, we've got detailed steps and resources to help you get started!_
25-
26-
<br />
11+
This repository is a space where developers of all levels, especially **beginners**,
12+
can contribute, showcase their creativity.
13+
Whether you're a seasoned developer or writing your first line of code,
14+
we'd love to see your animated artwork using only **HTML** and **CSS**
15+
> [!IMPORTANT]
16+
> no **JavaScript** or **images** or **SVG** allowed!
2717
2818
## 🌟 Why Contribute?
2919

3020
- **Gain GitHub experience** by contributing to open-source repositories.
3121
- **Join a supportive community** where you can share your creativity and get feedback in our Discord.
3222
- **Enhance your skills** in HTML and CSS while learning GitHub workflows.
3323

34-
<br />
3524

36-
## 📝 Contribution Guidelines
3725

26+
## 🎯 Objective Overview
27+
Create an animation using CSS and HTML only (no JavaScript, no SVG).
28+
A [CSS animation](https://developer.mozilla.org/fr/docs/Web/CSS/animation) refers to the css rule `animation`.
29+
30+
The purpose is to display a creative and looping animation
31+
*( alike animation in GIFs )*
32+
33+
### Should
34+
- the animation should be looping
35+
- the animation should not require any user interaction ( click, hover, etc ... )
36+
### Should not
37+
An animation should not be:
38+
- a form,
39+
- a portfolio,
40+
- a button to click on,
41+
- a landing page, etc...
42+
*( which are elements requiring user interaction )*
43+
44+
Here is an example of an expected animation:
45+
<img src="./public/example-animation.gif" alt="triangle" />
46+
47+
### ☝️ Keep in mind
3848
We keep things simple! Here are the rules for contributing:
3949

4050
- Use **HTML** and **CSS** only. No **JavaScript**. No **Images/SVGs**.
4151
- Your project must include **at least one animation**.
4252
- Don't copy work from others. Make sure your code is **original** so you can showcase your own skills.
4353

54+
55+
## 🚀 How to contribute
56+
> [!TIPS]
57+
> 📌 Don't worry if it's your first time contributing—below,
58+
we've got detailed steps and resources to help you get started!***
59+
60+
<details>
61+
<summary>💡 Development Workflow</summary>
62+
63+
1. **Fork the repo** to your GitHub account.
64+
2. **Clone your fork** to your local machine.
65+
3. **Create a branch**, you should not be working in the main/master branch
66+
4. Create a new directory in the Art directory. Naming it <your_github_username>-<your_arts_name>
67+
5. Create your animated HTML and CSS artwork.
68+
6. Pull down recent changes
69+
7. **Submit a pull request (PR)** with your animated artwork
70+
*Ensure to review yourself in Github during your PR submission
71+
before definitely submitting your PR*
72+
8. **OPTIONAL** [Tweet about making your first Hacktoberfest pull request](https://ctt.ac/36L1C), and you're done! 🎉
73+
</details>
74+
75+
<br>
76+
77+
We keep things simple! Here are the rules for contributing:
78+
- Use **HTML** and **CSS** only. No **JavaScript**. No **Images/SVGs**.
79+
- Your project must include **at least one animation**.
80+
- Don't copy work from others. Make sure your code is **original** so you can showcase your own skills.
81+
4482
<br />
4583

46-
## 🔥 Step-by-Step Contribution Guide
84+
### 🔥 Contribution Guide: Step-by-Step
4785

48-
### 1. Fork This Repository
86+
#### 1. Fork This Repository
4987

50-
If you're new to GitHub, no worries! Forking a repository means creating a copy of this project under your GitHub account. Check out these beginner-friendly resources for more help:
88+
If you're new to GitHub, no worries!
89+
Forking a repository means creating a copy
90+
of this project under your GitHub account.
91+
Check out these beginner-friendly resources for more help:
5192

5293
- [Start Here Guidelines](https://github.com/zero-to-mastery/start-here-guidelines)
5394
- [How to Fork a Repository](https://docs.github.com/en/get-started/quickstart/fork-a-repo)
5495
- [Aldo's Contributing to Github video](https://www.youtube.com/watch?v=uQLNFRviB6Q)
5596

56-
### 2. Clone Your Fork
97+
<br>
5798

58-
Once you've forked the repo, clone it to your local machine so you can work on it. Use this command:
99+
#### 2. Clone Your Fork
100+
101+
Once you've forked the repo, clone it to your local machine
102+
so you can work on it.
103+
Use this command:
59104

60105
```bash
61106
git clone https://github.com/<your-github-username>/Animation-Nation.git
62107
```
63108

64-
### 3. Create A Branch
109+
<br>
110+
111+
#### 3. Create A Branch
112+
Create a new branch from `master` or `main`
113+
*Working in the `master` or `main` branch is often frowned upon
114+
and are usually expected to branch off. Branching also helps
115+
to reduce the chance of a merge conflict.*
65116

66-
Working in the master or main branch is often frowned upon and are usually expected to branch off. Branching also helps to reduce the chance of a merge conflict.
117+
<br>
67118

68-
### 4. Create Your Artwork
119+
120+
#### 4. Create Your Artwork
69121

70122
Now for the fun part! Inside the `Art/` folder:
123+
> [!WARNING]
124+
> It is important to name the directory and your files exactly as mentioned
125+
126+
> [!NOTE]
127+
> Per contribution folder: it should have only 3 files [ `index.html`, `styles.css`, `meta.json` ]
71128
72-
- Create a new directory named: <github_username>-<art_name> eg. `mattcsmith-helloworld`.
129+
- Create a new directory named:
130+
`<github_username>-<art_name>` eg. `mattcsmith-helloworld`.
73131
- Inside **your** folder, create an `index.html` file
74132
- Inside **your** folder, create an `styles.css` file
75133
- Inside **your** folder, create an `meta.json` file
76134
to specify your art name, github author and github link
77-
Note: copy the following snippet and replace only the values with your own details,
78-
Do not change the JSON keys.
135+
Note:
136+
- copy the following snippet ( without the comment )
137+
- and replace only the values with your own details.
138+
- Do not change the JSON keys
79139

80140
```json
81141
// Example
82142
{
83-
"artName": "hello world",
143+
"artName": "triangle",
84144
"githubHandle": "mattcsmith"
85145
}
86146
```
87147

88-
- Use these to create your **animated artwork** — let your creativity flow!
148+
🎉 Use these to create your **animated artwork** — let your creativity flow!
89149

90-
⚠️ It is important to name the directory and your files exactly as mentioned above ⚠️
150+
<br>
91151

92-
### 5. Submit a Pull Request (PR)
152+
#### 5. Submit a Pull Request (PR)
93153

94-
After completing your artwork, you are now ready to create a pull request and have it added to the collection.
95-
Remembering to first pull down the recent changes from to the upstream, commit your changes, push them to your forked repo, and submit a PR. If you're unfamiliar with pull requests, check out the following resources or drop a message in the Hacktoberfest channel on Discord.
154+
After completing your artwork, you are now ready to create
155+
a pull request and have it added to the collection.
96156

157+
158+
Remembering
159+
- to first **pull down** the recent changes from to the upstream,
160+
- **commit** your changes,
161+
- **push** them to your forked repo,
162+
and submit a PR.
163+
If you're unfamiliar with pull requests, check out the following resources
164+
or drop a message in the Hacktoberfest channel on Discord.
97165
- [Creating a Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests)
98166
- [Aldo's Contributing to Github video](https://www.youtube.com/watch?v=uQLNFRviB6Q)
99167

100-
### 6. [ OPTIONAL ] Tweet about your progress
168+
<br>
169+
170+
#### 6. OPTIONAL - Tweet about your progress
171+
Optionally you can [Tweet about making your first Hacktoberfest pull request](https://ctt.ac/36L1C) on X
101172

102-
Optinonally you can [Tweet about making your first Hacktoberfest pull request](https://ctt.ac/36L1C) on X
173+
<br>
103174

104175
---
105176

106-
## ⚠️ Important Notes
177+
## ⚠️ Important Notes Summary
107178

108-
- You can contribute multiple animations, Just create a new directory with your <github_username>-<art_name>
179+
- You can contribute multiple animations, just create
180+
a new directory with your `<github_username>-<art_name>`
181+
- Ensure to have the **3 required files**
109182
- Ensure that you have not modified any other file outside of your own directory
110-
- Ensure that your directory includes an `index.html` and `styles.css`, these **exact names are important**.
111-
- Do **NOT** include any images, svg's or other files. Optimised images will be generate automatically to keep the repository at a managable size.
183+
- Ensure that your directory includes an `index.html` and `styles.css`,
184+
these **exact names are important**.
185+
- Do **NOT** include any **images**, **SVG**'s or **other files**.
186+
Optimized images will be generate automatically
187+
to keep the repository at a manageable size.
112188

113-
---
114-
115-
## 🙌 Let's Connect!
189+
For maintenance reasons:
190+
- Keep checking regularly your pull requests to address provided reviews
191+
Reviewers will take time to check PRs, provide reviews and handle all
192+
the repository PRs.
116193

117-
We encourage everyone to share their progress, ask for help, or discuss ideas in the ZTM Discord community. We're here to support you!
118-
119-
Ready? Let’s make some amazing CSS animations together! 🚀
194+
- After a while of no activity after a reviewer gave you reviews:
195+
- a label `stale` could be set
196+
- and/or the PR could be closed
120197

121198
---
122199

123-
<img src="https://images.ctfassets.net/aq13lwl6616q/51gDR7DozuNea9fltdgHIc/0c8577f24eaa1b33c40656a522f2d1db/hacktoberfest_discord_banner.png?h=250" align="center" />
200+
## 🙌 Let's Connect !
124201

125-
---
202+
We encourage everyone to share their progress,
203+
ask for help, or discuss ideas in the ZTM Discord community.
204+
We're here to support you!
205+
206+
Ready? Let’s make some amazing CSS animations together! 🚀

public/example-animation.gif

92.4 KB
Loading

0 commit comments

Comments
 (0)