Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Chain Migration E2E test in admin E2E tests #1980

Open
Tracked by #1720
lumtis opened this issue Apr 3, 2024 · 0 comments
Open
Tracked by #1720

Enable Chain Migration E2E test in admin E2E tests #1980

lumtis opened this issue Apr 3, 2024 · 0 comments
Assignees
Labels
E2E E2E tests related

Comments

@lumtis
Copy link
Member

lumtis commented Apr 3, 2024

The PR: #1900 add a new TestMigrateChainSupportName E2E test for chain migration

This test is currently commented out in the list of admin E2E tests to run in cmd/zetae2e/local/local.go for the following reasons:

We currently have an issue to track using EIP1559 #1952 however this might bring some unexpected behavior therefore the fix was not implemented in the PR above.

One of the following solution should be considered and then the test can be enabled back:

  • Move away from anvil and use a evm localnet that support pre-EIP1559 txs (although it seems Anvil is the most reliable option and geth doesn't support custom chain ID)
  • Implement EIP1559 as per the issue above
  • Use a patched version of Anvil in the future

This test should be considered to be added the next time we integrate a new EVM chain (we need to fix about adding it to the epic if we create a new epic for a chain intergration)

@lumtis lumtis added the E2E E2E tests related label Apr 3, 2024
@lumtis lumtis self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E E2E tests related
Projects
None yet
Development

No branches or pull requests

1 participant