Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TON.TON ZRC-20 gasLimit should match contract const #3654

Open
swift1337 opened this issue Mar 6, 2025 · 4 comments
Open

TON.TON ZRC-20 gasLimit should match contract const #3654

swift1337 opened this issue Mar 6, 2025 · 4 comments

Comments

@swift1337
Copy link
Contributor

swift1337 commented Mar 6, 2025

zq fungible list-foreign-coins --output json | jq '.foreignCoins[] | select(.symbol | contains("TON"))'
{
  "zrc20_contract_address": "0x54Bf2B1E91FCb56853097BD2545750d218E245e1",
  "asset": "",
  "foreign_chain_id": "2015141",
  "decimals": 9,
  "name": "ZetaChain ZRC20 TON Testnet TON",
  "symbol": "TON.TON",
  "coin_type": "Gas",
  "gas_limit": "21000", // should be changed
  "paused": false,
  "liquidity_cap": "0"
}

But in GW contract it's 17500: https://github.com/zeta-chain/protocol-contracts-ton/blob/053a6fd7fc1d5e7604a2359d5a06569aba0640fe/contracts/gateway.fc#L35

@swift1337
Copy link
Contributor Author

@morde08 bumping this

@swift1337 swift1337 changed the title TON.TON ForeignCoin gasLimit should match contract const TON.TON ZRC-20 gasLimit should match contract const Mar 14, 2025
@swift1337
Copy link
Contributor Author

AFAIK now this is configured in ZRC20, rather than in x/fungible cc @lumtis

@lumtis
Copy link
Member

lumtis commented Mar 14, 2025

Yes, the value in the foreign coin is not used at all, this value has been overlooked for a long time. I added the PR to deprecate the field but this would actually make more sense to just remove it since client should not read this value at all

@morde08
Copy link
Contributor

morde08 commented Mar 14, 2025

@swift1337 So we'll eventually remove all of the gas_limit fields anyway so this issue can be closed yeah?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants