Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner cctx error message when not enough funds to pay for revert tx #3696

Open
lumtis opened this issue Mar 12, 2025 · 2 comments · May be fixed by #3709
Open

Cleaner cctx error message when not enough funds to pay for revert tx #3696

lumtis opened this issue Mar 12, 2025 · 2 comments · May be fixed by #3709
Assignees

Comments

@lumtis
Copy link
Member

lumtis commented Mar 12, 2025

Describe the Issue
We made improvement in the cctx error info however one common error message that might still be unclear to the user is when there is not enough funds to pay for the revert tx:
Example

    error_message_revert: '{"type":"internal_error","error":"outTxGasFee(10000000)
      more than available gas for tx (1000000) | Identifiers : 0xdfe280f111900991daa5c25d73a5ae134022b81616d3325945ac157b5394b598-104-104-0
      : not enough gas"}'

The revert fee tx is 10000000, the cctx contains 1000000 and can't pay it.

The error message should be made ux friendly:

fee for the revert tx costs 10000000 unit of gas tokens, the cctx only contains 1000000
@kingpinXD
Copy link
Contributor

We should remove the Identifiers : 0xdfe280f111900991daa5c25d73a5ae134022b81616d3325945ac157b5394b598-104-104-0 field completely in my opinion , its unused can adds additional log .

@kingpinXD
Copy link
Contributor

the message is added to error_message_revert field , I think mentioned revert on the logs as well would be redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants