Skip to content

Commit a305d01

Browse files
authored
Merge pull request #662 from e-kwsm/virtual
style: remove redundant 'virtual' for the 'override'-specified functions
2 parents 9d7fcbf + 081e8a3 commit a305d01

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: tests/test_dom_traverse.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@ struct test_walker: xml_tree_walker
896896
#endif
897897
}
898898

899-
virtual bool begin(xml_node& node) PUGIXML_OVERRIDE
899+
bool begin(xml_node& node) PUGIXML_OVERRIDE
900900
{
901901
log += STR("|");
902902
log += depthstr();
@@ -908,7 +908,7 @@ struct test_walker: xml_tree_walker
908908
return ++call_count != stop_count && xml_tree_walker::begin(node);
909909
}
910910

911-
virtual bool for_each(xml_node& node) PUGIXML_OVERRIDE
911+
bool for_each(xml_node& node) PUGIXML_OVERRIDE
912912
{
913913
log += STR("|");
914914
log += depthstr();
@@ -920,7 +920,7 @@ struct test_walker: xml_tree_walker
920920
return ++call_count != stop_count && xml_tree_walker::end(node);
921921
}
922922

923-
virtual bool end(xml_node& node) PUGIXML_OVERRIDE
923+
bool end(xml_node& node) PUGIXML_OVERRIDE
924924
{
925925
log += STR("|");
926926
log += depthstr();

Diff for: tests/test_write.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ struct test_writer: xml_writer
237237
{
238238
std::basic_string<char_t> contents;
239239

240-
virtual void write(const void* data, size_t size) PUGIXML_OVERRIDE
240+
void write(const void* data, size_t size) PUGIXML_OVERRIDE
241241
{
242242
CHECK(size % sizeof(char_t) == 0);
243243
contents.append(static_cast<const char_t*>(data), size / sizeof(char_t));
@@ -687,7 +687,7 @@ TEST(write_flush_coverage)
687687
#ifndef PUGIXML_NO_EXCEPTIONS
688688
struct throwing_writer: xml_writer
689689
{
690-
virtual void write(const void*, size_t) PUGIXML_OVERRIDE
690+
void write(const void*, size_t) PUGIXML_OVERRIDE
691691
{
692692
throw std::runtime_error("write failed");
693693
}

0 commit comments

Comments
 (0)