-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving sljit's documentation #285
Comments
Thank you for the help. I always wanted to be things simple, so the sljit documentation is in https://github.com/zherczeg/sljit/blob/master/sljit_src/sljitLir.h The readme and the website is just some general overview, and not intended to be a documentation. It could be, but I have no resources to do it. The doc directory is contributed by others, I have never touched anything there. So if you want to improve things there, feel free to do it. Probably lots of things are outdated there. If you want to add / replace things with static html pages, I am ok with it. @carenas or @invertego who cotributed to doc/ might be also interested in your changes. |
Thanks for the quick reply!
I have been a bit unclear in my usage of the word "documentation".
Just to clarify: does that mean a static documentation site generator would be an option for you? The structure could look like this (going with docusaurus here as it is the one I know best; would be surprised though if the others use a drastically different approach): sljit
├── .github/workflows
│ ├── actions.yml
│ └── deploy-website.yml # automatically deploy website on pull into master
├── regex_src
├── sljit_src
├── test_src
├── website # embedded docusarus site
│ ├── docs # existing / revamped documentation in markdown
│ │ ├── overview.md
│ │ ├── supported-platforms.md
│ │ └── ...
│ ├── src # some scaffolding for the home page
│ ├── ...
│ └── package.json # docusaurus dependencies (can be ignored by most users / developers)
├── ...
└── README Documentation / examples / tutorials could then be simply written as markdown and deployed automatically on pull. Users / developers of sljit would not need to worry about the website details and could ignore the NodeJs project most of the time. In case you would rather keep things separated as they are now (website as static html in I would not mind either way, so let me know what you prefer (or if you have something different in mind) :-) |
I like markdown, and in fact I prefer it over html. Easier to maintain, and I think github can nicely display it. I would keep the docs subdirectory though:
The generated html pages could be manually copied into the gh-pages branch. |
one useful "feature" of the current state is that the examples are valid C code (which can be tweaked) and can be built by invoking the fact that the contents of those files are duplicated is bad though, but if you are going to generate a "website" then it will be better to keep them AS-IS (maybe adding comments) and process them to generate the expected output IMHO. |
Good point, I almost forgot about that make target.
That should absolutely be possible with the framework, I will look into it. If time permits I hope I have something to show by the end of next week, but no promises 🙃 |
I have been using sljit for some time now and am quite happy with it :-)
One thing where I see room for improvement though is its documentation. There are currently 4 places where documentation can be found (apart from the code itself):
doc/overview.txt
doc/tutorial
, which can AFAIK only be viewed on external pages like this oneThis makes it both hard for newcomers to find their way around, as well as contributors to keep the different sources up to date and in sync.
I would like to help out and improve the documentation, but wanted to check with you first before putting time into a pull request. The reason being that I see roughly two ways to go about this:
gh-pages
branch, as well as documentation in themaster
branch) and only clean up / add some stuffI would suggest the latter strategy, as this would allow writing all the documentation in Markdown in one place and deploy it automatically via some GitHub workflows magic.
Let me know what you think :-)
The text was updated successfully, but these errors were encountered: