Fix padding size in Event #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to SDL_events.h, the SDL_Event union has 128 bytes of padding, but our Event has 128 bits. https://github.com/libsdl-org/SDL/blob/8eb57c5a420426f7b6d96f9c6afd0777c6137be6/include/SDL3/SDL_events.h#L1040
coat
force-pushed
the
fix-event-union-padding
branch
from
fe59c20 to
5ca93a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting an Illegal instruction error after my program ended normally, and during troubleshooting I noticed the Event union differed that what Zig translate-c was generating.
According to SDL_events.h, the SDL_Event union has 128 bytes of padding, but our Event has 128 bits.
After making this change, my program no longer crashes.