Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Reject a proposal #286

Closed
ashcherbakov opened this issue Mar 15, 2022 · 3 comments
Closed

Feature: Reject a proposal #286

ashcherbakov opened this issue Mar 15, 2022 · 3 comments
Assignees
Labels
Projects

Comments

@ashcherbakov
Copy link
Contributor

As a Trustee, I can reject a proposal, so that once more than 1/3 of rejects is received, the proposal goes to rejected state.

Notes:

  • It should not be possible to vote multiple times for the same Trustees, so once approve/reject is sent, no more votes are accepted from that Trustee
  • The rejected proposal should not be removed, but kept in the state for history purposes
  • All votes (rejects and approvals) must be stored and kept for the rejected proposals for the history purposes.
@ashcherbakov ashcherbakov added enhancement New feature or request size: L labels Mar 15, 2022
@ashcherbakov ashcherbakov added this to the v1.0: Main Net Launch milestone Mar 15, 2022
@ashcherbakov ashcherbakov added this to Backlog in DCL via automation Mar 15, 2022
@ashcherbakov ashcherbakov moved this from Backlog to To do in DCL Mar 15, 2022
@hawk248
Copy link
Collaborator

hawk248 commented Mar 22, 2022

Pre 1.0

@uabjabborov uabjabborov moved this from To do to In progress in DCL Apr 8, 2022
@uabjabborov
Copy link
Collaborator

@abdulla-ashurov, issue #288 seems to be related to this issue. Consider including it to implementation if applicable.

@abdulla-ashurov
Copy link
Collaborator

abdulla-ashurov commented Apr 8, 2022

Plan of attack for section Auth:

Create a message and a new entity:

  • Add a new command reject-add-account and create a new entity RejectedAccount with fields Account

Note: If we have more than 1/3 of rejects is received, the proposal goes to a new entity RejectedAccount.

Plan of attack for section Validator:

Create a message and a new entity:

  • Add a new command reject-disable-node and create a new entity RejectedNode with fields Account

Note: If we have more than 1/3 of rejects is received, the proposal goes to a new entity RejectedDisableNode.

Plan of attack for section PKI:

Create a message and a new entity:

  • Add a new command reject-x509-root-cert and create a new entity RejectedX509RootCert

Note: If we have more than 1/3 of rejects is received, the proposal goes to a new entity RejectedX509RootCert.

Plan of attack for section Upgrade:

Create a message and a new entity:

  • Add a new command reject-upgrade and create a new entity RejectedUpgrade

Note: If we have more than 1/3 of rejects is received, the proposal goes to a new entity RejectedUpgrade.

Check:

  • A Trustee should not vote multiple times for the same account, so once approve/reject is sent, no more votes are accepted from that Trustee
  • The rejected proposal should not be removed, but kept in state for historical purposes.
  • All votes (reject and approvals) must be stored and kept for the rejected proposals for historical purposes.

PR:

DCL automation moved this from In progress to Done Apr 16, 2022
DCL automation moved this from Done to To do Apr 16, 2022
@abdulla-ashurov abdulla-ashurov moved this from To do to In progress in DCL Apr 16, 2022
@abdulla-ashurov abdulla-ashurov moved this from In progress to In Review in DCL Apr 29, 2022
uabjabborov pushed a commit that referenced this issue May 6, 2022
DCL automation moved this from In Review to Done May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
DCL
  
Done
Development

No branches or pull requests

4 participants