Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"dcld tx dclupgrade approve-upgrade" help has the wrong --note flag #352

Open
j2fong opened this issue May 5, 2022 · 0 comments
Open

"dcld tx dclupgrade approve-upgrade" help has the wrong --note flag #352

j2fong opened this issue May 5, 2022 · 0 comments

Comments

@j2fong
Copy link

j2fong commented May 5, 2022

The help page is wrong for approve-upgrade. It stated,

  --note string              Note to add a description to the transaction (previously --memo)

Which doesn't work. It should just be --info.
We should just remove that.

`$ dcld tx dclupgrade approve-upgrade -h
Approve proposed upgrade with given name

Usage:
dcld tx dclupgrade approve-upgrade --name [name] --info [info] [flags]

Flags:
-a, --account-number uint The account number of the signing account (offline mode only)
-b, --broadcast-mode string Transaction broadcasting mode (sync|async|block) (default "sync")
--dry-run ignore the --gas flag and perform a simulation of a transaction, but don't broadcast it
--fee-account string Fee account pays fees for the transaction instead of deducting from the signer
--fees string Fees to pay along with transaction; eg: 10uatom
--from string Name or address of private key with which to sign
--gas string gas limit to set per-transaction; set to "auto" to calculate sufficient gas automatically (default 200000)
--gas-adjustment float adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored (default 1)
--gas-prices string Gas prices in decimal format to determine the transaction fee (e.g. 0.1uatom)
--generate-only Build an unsigned transaction and write it to STDOUT (when enabled, the local Keybase is not accessible)
-h, --help help for approve-upgrade
--info string Optional information/notes for approval, proposal or revocation
--keyring-backend string Select keyring's backend (os|file|kwallet|pass|test|memory) (default "test")
--keyring-dir string The client Keyring directory; if omitted, the default 'home' directory will be used
--ledger Use a connected Ledger device
--name string Upgrade name
--node string : to tendermint rpc interface for this chain (default "tcp://localhost:26657")
--note string Note to add a description to the transaction (previously --memo)
--offline Offline mode (does not allow any online functionality
-o, --output string Output format (text|json) (default "json")
-s, --sequence uint The sequence number of the signing account (offline mode only)
--sign-mode string Choose sign mode (direct|amino-json), this is an advanced feature
--timeout-height uint Set a block timeout height to prevent the tx from being committed past a certain height
-y, --yes Skip tx broadcasting prompt confirmation

Global Flags:
--chain-id string The network chain ID (default "dcl")
--home string directory for config and data (default "/home/ubuntu/.dcl")
--log_format string The logging format (json|plain) (default "plain")
--log_level string The logging level (trace|debug|info|warn|error|fatal|panic) (default "info")
--trace print out full stack trace on errors
`

@ashcherbakov ashcherbakov added bug Something isn't working size: M maintenance and removed bug Something isn't working size: M labels Oct 25, 2022
@ashcherbakov ashcherbakov removed this from the v1.5: Post Main Net Launch milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants