Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests refactoring for all modules #512

Open
DenisRybas opened this issue Aug 17, 2023 · 0 comments
Open

Unit tests refactoring for all modules #512

DenisRybas opened this issue Aug 17, 2023 · 0 comments
Assignees
Labels
refactoring Code refactoring size: L

Comments

@DenisRybas
Copy link
Collaborator

Scope:

  • Unit tests from all modules
  • Two goals:
    • check test coverage
    • refactoring/simplification

Details:

  • make sure Unit Tests coverage is enough
  • simplify the unit tests (simplify initialisation):
    • simplify initialisation and test stricture by creating helper functions, for example

      ```
      // prepare
      add_vendor()
      add_root_cert(cert_path)
      
      // execution
      add_revocation_point()
      
      //check
      asserts... 
      ```
      
    • get rid of magic numbers (for example, make sure VID constant is issued instead of hard-coded values)

  • improve error messages (all error text needs to be in errors.go's NewXXX methods, not error strings created on the fly).
@DenisRybas DenisRybas self-assigned this Aug 17, 2023
@DenisRybas DenisRybas added enhancement New feature or request refactoring Code refactoring and removed enhancement New feature or request labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring size: L
Projects
None yet
Development

No branches or pull requests

1 participant