Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting certificate information from different lists or all (follow up from #610) #612

Open
jcps07 opened this issue Oct 17, 2024 · 3 comments

Comments

@jcps07
Copy link
Contributor

jcps07 commented Oct 17, 2024

In addition to what is requested in issue #610:

Update /dcl/pki/certificates in 1.4 so that it will ONLY return PAA, PAI and DAC if PAI and DAC have been uploaded in device attestation chain.
Implement another API that returns certificates regardless of PKI chain e.g. inclusive of DA or NOC.

To also consider getting certificate from Node Credentials based on Subject and/or SKID, so it'd be something like this:

API Description
/dcl/pki/certificates Query certificate by Subject and/or SKID in Device Attestation list (PAA, PAI, DAC) (#610)
/dcl/pki/all-noc-certificates Query certificate by Subject and/or SKID in all Node Credentials list (RCAC, ICA, NOC).
Not just from specific VID as /dcl/pki/noc-certificates/{vid}/{subject_key_id} does already
/dcl/pki/all-certificates Query certificate by Subject and/or SKID from Device Attestation and Node Credentials (#610)

All of these will get matching cert(s) of different types of certs (PAA/PAI/DAC or RCAC/ICA/NOC or both), not just Roots.

@jcps07
Copy link
Contributor Author

jcps07 commented Oct 28, 2024

Note: The proposed query is still to be triaged. (/dcl/pki/all-certificates)

@robszewczyk
Copy link

One comment re: /dcl/pki/all-certificates -- documentation should be a bit more forward looking and make it clear that it should return all certificates. See #611 for a more forward looking certificate.proto

@hawk248
Copy link
Collaborator

hawk248 commented Oct 31, 2024

/dcl/pki/all-certificates is it needed?
Use case: Given a SKI, allow user to query DCL to find out it it exists and what type it is.
This can be deferred. May be useful in the future.

DCL TT - OK to proceed implementation on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants