Skip to content

std.zig.AstGen: properly handle grouped_expression #25849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
+10 −1
Merged

std.zig.AstGen: properly handle grouped_expression #25849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/std/zig/AstGen.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2607,7 +2607,7 @@ fn blockExprStmts(gz: *GenZir, parent_scope: *Scope, statements: []const Ast.Nod
.assign_mul_wrap => try assignOp(gz, scope, statement, .mulwrap),

.grouped_expression => {
inner_node = tree.nodeData(statement).node_and_token[0];
inner_node = tree.nodeData(inner_node).node_and_token[0];
continue;
},

Expand Down
9 changes: 9 additions & 0 deletions test/cases/compile_errors/doubled_grouped_expr_as_stmt.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
pub export fn entry() void {
((1 + 1)); // makes sure that the doubled grouped_expression does not cause an endless loop in AstGen.
}

// error
//
// :2:9: error: value of type 'comptime_int' ignored
// :2:9: note: all non-void values must be used
// :2:9: note: to discard the value, assign it to '_'
Loading