update default camera position (#760)

* set camera to `5, 5, 5`

* update camera default position

Author: PythonFZ

app/src/App.tsx

@@ -87,7 +87,7 @@ export default function App() {
 	const [roomName, setRoomName] = useState<string>("");
 	const [geometries, setGeometries] = useState<any>([]);
 	const [cameraAndControls, setCameraAndControls] = useState<any>({
-		camera: new THREE.Vector3(0, 0, 0),
+		camera: new THREE.Vector3(5, 5, 5),
 		target: new THREE.Vector3(0, 0, 0),
 	});
 	// TODO: initial values are wrong for orbitcontrolstarget and camperaPosition

app/src/components/cameraAndControls.tsx

@@ -18,6 +18,7 @@ import * as THREE from "three";
 import { getCentroid, useCentroid } from "./particlesEditor";
 
 const zeroVector = new THREE.Vector3(0, 0, 0);
+const initialCameraVector = new THREE.Vector3(5, 5, 5);
 const upVector = new THREE.Vector3(0, 1, 0);
 
 const MoveCameraTarget = forwardRef(
@@ -164,7 +165,7 @@ const CameraAndControls: React.FC<CameraAndControlsProps> = ({
 	// if the camera positions and target positions is default, adapt them to the scene
 	useEffect(() => {
 		if (
-			cameraAndControls.camera.equals(zeroVector) &&
+			cameraAndControls.camera.equals(initialCameraVector) &&
 			cameraAndControls.target.equals(zeroVector)
 		) {
 			const resetCamera = getResetCamera();

tests/test_camera.py

@@ -6,7 +6,7 @@ def test_camera(server, s22):
     vis = ZnDraw(url=server, token="test_token")
     vis.extend(s22)
 
-    assert vis.camera["position"] == [0, 0, 0]
+    assert vis.camera["position"] == [5, 5, 5]
     assert vis.camera["target"] == [0, 0, 0]
     assert len(vis.camera) == 2
 

zndraw/zndraw.py

@@ -549,7 +549,7 @@ def camera(self) -> CameraData:
             socket=self._refresh_client,
         )
         if "position" not in camera_dct:
-            camera_dct["position"] = [0, 0, 0]
+            camera_dct["position"] = [5, 5, 5]
         if "target" not in camera_dct:
             camera_dct["target"] = [0, 0, 0]
         return camera_dct