Add new InfoBox V maximum efficiency

Author: zinuzoid

src/Computer/TaskComputer.cpp

@@ -99,6 +99,8 @@ TaskComputer::ProcessMoreTask(const MoreData &basic,
   else
     calculated.V_stf = calculated.common_stats.V_dolphin;
 
+  calculated.V_max_eff = calculated.common_stats.V_max_eff;
+
   if (calculated.task_stats.current_leg.vector_remaining.IsValid()) {
     const GeoVector &v = calculated.task_stats.current_leg.vector_remaining;
     calculated.auto_zoom_distance = v.distance;

src/Engine/GlideSolvers/GlidePolar.cpp

@@ -340,6 +340,18 @@ GlidePolar::SpeedToFly(const AircraftState &state,
   return std::max(Vmin, V_stf * g_scaling);
 }
 
+double
+GlidePolar::SpeedToFlyMaxEfficient(const AircraftState &state,
+                                   const GlideResult &solution) const noexcept
+{
+  assert(IsValid());
+
+  const auto head_wind = solution.IsDefined() ? solution.head_wind : 0.;
+  const auto sink_rate = -state.netto_vario;
+
+  return SpeedToFly(sink_rate, head_wind);
+}
+
 double
 GlidePolar::GetTotalMass() const noexcept
 {

src/Engine/GlideSolvers/GlidePolar.hpp

@@ -417,6 +417,9 @@ class GlidePolar
   double SpeedToFly(const AircraftState &state, const GlideResult &solution,
                    bool block_stf) const noexcept;
 
+  [[gnu::pure]]
+  double SpeedToFlyMaxEfficient(const AircraftState &state, const GlideResult &solution) const noexcept;
+
   /**
    * Calculate speed-to-fly according to MacCready dolphin theory
    * with ring setting at current MC value, at specified netto sink rate

src/Engine/Task/Stats/CommonStats.cpp

@@ -26,6 +26,7 @@ CommonStats::Reset() noexcept
 
   V_block = 0;
   V_dolphin = 0;
+  V_max_eff = 0;
 
   current_risk_mc = 0;
   height_min_working = 0;

src/Engine/Task/Stats/CommonStats.hpp

@@ -56,6 +56,8 @@ class CommonStats
   double V_block;
   /** Dolphin speed to fly */
   double V_dolphin;
+  /** Maximum efficiency speed to fly */
+  double V_max_eff;
 
   /** Risk MC setting (m/s) */
   double current_risk_mc;

src/Engine/Task/TaskManager.cpp

@@ -218,6 +218,10 @@ TaskManager::UpdateCommonStatsPolar(const AircraftState &state) noexcept
     risk_polar.SpeedToFly(state,
                           GetStats().current_leg.solution_remaining,
                           false);
+
+  common_stats.V_max_eff =
+    glide_polar.SpeedToFlyMaxEfficient(state,
+                          GetStats().current_leg.solution_remaining);
 }
 
 void

src/InfoBoxes/Content/Factory.cpp

@@ -1202,6 +1202,15 @@ static constexpr MetaData meta_data[] = {
     UpdateInfoBoxFuelRemain,
   },
 
+  // e_Speed_Maximum_Efficiency
+  {
+    N_("Speed maximum efficiency"),
+    N_("V max eff"),
+    N_("Best glide speed based on vario and wind"),
+    UpdateInfoBoxSpeedMaximumEfficiency,
+    maccready_panels,
+  },
+
 };
 
 static_assert(ARRAY_SIZE(meta_data) == NUM_TYPES,

src/InfoBoxes/Content/MacCready.cpp

@@ -26,7 +26,7 @@ SetVSpeed(InfoBoxData &data, double value) noexcept
  * Subpart callback function pointers
  */
 
-static constexpr InfoBoxPanel panels[] = {
+constexpr InfoBoxPanel maccready_panels[] = {
   { N_("Edit"), LoadMacCreadyEditPanel },
   { N_("Setup"), LoadMacCreadySetupPanel },
   { nullptr, nullptr }
@@ -35,7 +35,7 @@ static constexpr InfoBoxPanel panels[] = {
 const InfoBoxPanel *
 InfoBoxContentMacCready::GetDialogContent() noexcept
 {
-  return panels;
+  return maccready_panels;
 }
 
 /*

src/InfoBoxes/Content/MacCready.hpp

@@ -5,6 +5,8 @@
 
 #include "InfoBoxes/Content/Base.hpp"
 
+extern const InfoBoxPanel maccready_panels[];
+
 class InfoBoxContentMacCready : public InfoBoxContent
 {
 public:

src/InfoBoxes/Content/Speed.cpp

@@ -117,3 +117,16 @@ UpdateInfoBoxSpeedGroundAndTAS(InfoBoxData &data) noexcept
   }
 
 }
+
+void
+UpdateInfoBoxSpeedMaximumEfficiency(InfoBoxData &data) noexcept
+{
+  // Set Value
+  const DerivedInfo &calculated = CommonInterface::Calculated();
+  data.SetValueFromSpeed(calculated.V_max_eff, false);
+
+  if(calculated.head_wind_available)
+    data.SetCommentFromSpeed(calculated.head_wind, false, _T("HW:"));
+  else
+    data.SetCommentInvalid();
+}

src/InfoBoxes/Content/Speed.hpp

@@ -26,3 +26,6 @@ UpdateInfoBoxSpeedDolphin(InfoBoxData &data) noexcept;
 
 void
 UpdateInfoBoxSpeedGroundAndTAS(InfoBoxData &data) noexcept;
+
+void
+UpdateInfoBoxSpeedMaximumEfficiency(InfoBoxData &data) noexcept;

src/InfoBoxes/Content/Type.hpp

@@ -169,6 +169,7 @@ namespace InfoBoxFactory
     e_HeightAGL_T_O,
 
     e_Fuel_Remain,
+    e_Speed_Maximum_Efficiency,
 
     e_NUM_TYPES /* Last item */
   };

src/NMEA/Derived.hpp

@@ -133,6 +133,9 @@ struct DerivedInfo:
   /** Speed to fly block/dolphin (m/s) */
   double V_stf;
 
+  /** Speed to fly maximum efficiency (m/s) */
+  double V_max_eff;
+
   /** Auto QNH calculation result. */
   AtmosphericPressure pressure;
   Validity pressure_available;