Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internally handle commit failures when rebalancing #242

Closed
svroonland opened this issue Nov 17, 2020 · 3 comments
Closed

Internally handle commit failures when rebalancing #242

svroonland opened this issue Nov 17, 2020 · 3 comments

Comments

@svroonland
Copy link
Collaborator

Committing when rebalancing will throw a RebalanceInProgressException. We should at the least include this in Offset.commitOrRetry or just completely handle it internally. If users want to customize commit behavior when rebalancing is going on for some reason, they can still observe the rebalancing diagnostic events.

Coming from #241

@Wosin
Copy link

Wosin commented Mar 30, 2021

Happy to at least take a crack at this.

@svroonland
Copy link
Collaborator Author

Much appreciated @Wosin!

However, I think I was too quick to create this issue though. This situation should not occur, since commits are not executed when rebalance is in progress. From Runloop lines 320:322.

      newPendingCommits <- if (!stillRebalancing && state.pendingCommits.nonEmpty)
                            doCommit(state.pendingCommits).as(Nil)
                          else ZIO.succeed(state.pendingCommits)

@svroonland
Copy link
Collaborator Author

Closing this, as explained above I'm pretty sure I falsely considered this to be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants