Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add acceptance checkbox to pr template #312

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eliobischof
Copy link
Member

We have acceptance tests now.
This PR adds some guidance about our expectations on new PRs regarding acceptance tests.
Also, it clarifies how the goals of integration and acceptance tests differ.

Completes #7
Relates to #51

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 0:46am

@eliobischof eliobischof self-assigned this Dec 5, 2024
@eliobischof eliobischof marked this pull request as ready for review December 5, 2024 12:44
@eliobischof
Copy link
Member Author

@peintnermax please mark the check for acceptance tests as required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant