Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote qa to prod: smaller fixes #316

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Promote qa to prod: smaller fixes #316

merged 11 commits into from
Dec 13, 2024

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Dec 11, 2024

  • Consider accept-language header to set language if no cookie is set
  • Add missing chinese translations
  • fix an issuer where users without mfa could not change their password when mfa was enforced
  • fix consistency of resend code button placement
  • TOTP authenticator design change
  • fixes an issue where a U2F method could not be set up on localhost
  • use default org on account selector if no organization param set

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:20am

@peintnermax peintnermax marked this pull request as ready for review December 11, 2024 07:59
…ll other checks after pws check, totp design
@peintnermax peintnermax merged commit 9e03dae into main Dec 13, 2024
8 checks passed
@peintnermax peintnermax deleted the qa branch December 13, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants