Skip to content

PROTOTYPE: real 2026-11-03 sync on the sharded CI shape (do not merge) - #56

Closed
ziyadakl wants to merge 124 commits into
custom-v2from
proto/sync-2026-11-03-ci
Closed

ziyadakl wants to merge 124 commits into
custom-v2from
proto/sync-2026-11-03-ci

Conversation

@ziyadakl

@ziyadakl ziyadakl commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Throwaway measurement for ziyadakl/tokenmaxxing#107: today's real Upstream merge (cefb544, 121 commits, resolved by a timed agent run) plus the v2 prototype CI shape from #55. Never merge.

🤖 Generated with Claude Code

juliusmarminge and others added 30 commits November 2, 2026 09:54
…tates (pingdotgg#29486)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#27138)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…und Agent (pingdotgg#27139)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…ingdotgg#27756)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…PR update (pingdotgg#29369)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…hile this device's sign-in loads (pingdotgg#29352)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…time (pingdotgg#29301)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

## Problem

PR watches stopped after eight failed host reads, so a prolonged network outage prevented later CI and review updates from reaching the thread.

## Change

Keep watches active after provider failures reported as `failed`. Read detail and activity concurrently without allowing an activity failure to cancel or hide a permanent detail failure. Repeated known permanent failures still stop the watch and notify the agent; rate limits still pause reads. Non-rate-limited GitHub HTTP 403 responses and GraphQL `FORBIDDEN` responses now use a distinct `forbidden` reason so access refusals are counted instead of retried indefinitely. GraphQL error types survive the client mapping, after the existing requested-reviewer fallback.

The provider's `failed` category also includes unclassified host and decode errors. Those continue retrying at the existing two-minute cadence until the watch ends or is stopped. A fixed outage deadline would recreate the recovery failure for longer outages.

## Scope and approval

This is a focused fix for an obvious bug in existing PR watch recovery, covered by the small bug-fix exception in CONTRIBUTING.md. The changes cover watcher recovery, a GitHub failure classification needed to preserve permanent-error handling, and their regression tests. The new server-side `forbidden` reason does not change RPC contracts or add settings.

## Verification

`vp run check:changed` passed, including 154 tests across five files. Regression coverage includes a 30-minute outage followed by one CI-success notification, mixed activity/detail failures, resetting a prior failure count, and repeated forbidden reads stopping the watch. Provider tests distinguish HTTP 403 and exclusively permanent GraphQL refusals from retryable HTTP 503 and mixed or untyped GraphQL errors. The mixed-failure and GraphQL classification cases failed before their fixes. Seven focused requested-reviewer fallback/refusal tests also pass.

Model: GPT 6.1 Sol. Harness: Codex.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…diff load (pingdotgg#27833)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…29640)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#29644)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Henry Stern <6068107+hstern@users.noreply.github.com>
Co-authored-by: Ashish Patil <7754022+ash663@users.noreply.github.com>
Co-authored-by: TinBane <363069+TinBane@users.noreply.github.com>
…tgg#29680)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…d newest usage (pingdotgg#29648)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ar again without going into focus mode (pingdotgg#26690)

Co-authored-by: nibarAhmed <nibarahmed0@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…g#26833)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#29775)

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
…very poll (pingdotgg#29813)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er a branch rename (pingdotgg#26125)

Co-authored-by: maria-rcks <maria@kuuro.net>
juliusmarminge and others added 24 commits November 2, 2026 18:33
…tance (pingdotgg#23198)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…turn absorbed its wake (pingdotgg#28010)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…ory scan ends (pingdotgg#29535)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tch (pingdotgg#29476)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…n starts (pingdotgg#28431)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ching origin (pingdotgg#27961)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…3804)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#23326)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Exotic209093 <134711311+Exotic209093@users.noreply.github.com>
Co-authored-by: Issue triage verification <triage@localhost>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#22661)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
… limit (pingdotgg#23192)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…29909)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	apps/server/src/auth/http.test.ts
#	apps/server/src/checkpointing/CheckpointDiffQuery.ts
#	apps/server/src/cloud/bootService.test.ts
#	apps/server/src/orchestration-v2/testkit/fixtures/shared.ts
#	apps/web/src/components/ChatView.tsx
#	packages/provider-core/src/server/failure.ts
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… rebalanced Test groups

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 3, 2026
@ziyadakl

ziyadakl commented Nov 3, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #58, the real sync (prepared merge 57236a8 plus 17 newer upstream commits). The prototype commits on this branch match proto/sync-speed patch for patch (9fc34bf, 23dc4e5).

@ziyadakl ziyadakl closed this Nov 3, 2026
@ziyadakl
ziyadakl deleted the proto/sync-2026-11-03-ci branch November 3, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.