Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge connected reverse engineered keys timelines #122

Open
Divide-By-0 opened this issue Oct 19, 2024 · 4 comments · May be fixed by #126
Open

Merge connected reverse engineered keys timelines #122

Divide-By-0 opened this issue Oct 19, 2024 · 4 comments · May be fixed by #126
Labels
bug Something isn't working low

Comments

@Divide-By-0
Copy link
Member

This case should not exist, it should be merged.

image
@Divide-By-0 Divide-By-0 added bug Something isn't working low labels Oct 19, 2024
@Divide-By-0 Divide-By-0 mentioned this issue Oct 29, 2024
Closed
@hhuntaa
Copy link

hhuntaa commented Oct 29, 2024

just to be sure do you want to merge them on the frontend or in the database?

hhuntaa added a commit to hhuntaa/archive.prove.email that referenced this issue Oct 29, 2024
@hhuntaa
fix: merges records with the same values
614fb2b 
fixes zkemail#122, i dont
know if this is exactly what you wanted so you might have to review it,
it merges records with the same values while keeping the earliest first
seen at date with the oldest last seen at date.
@hhuntaa hhuntaa linked a pull request Oct 29, 2024 that will close this issue
Open
@Divide-By-0
Copy link
Member Author

Divide-By-0 commented Nov 27, 2024 •
edited
Loading

Also, while these ones overlap, there are many keys which do not overlap, but if they have the same value, then we should in fact be merging those entries into one.

This should happen at the database level, because we want the API to return values that are as processed as possible.

@Divide-By-0
Copy link
Member Author

Here's another one that should be merged:

Image

@foolo
Copy link
Contributor

foolo commented Mar 14, 2025

I think this has two parts:

  • A one-time batch job to scan the db and merge existing duplicates. Also remember to use oldest "First seen" and the newest "Last seen" when merging.
  • Investigate the source code and try to figure out how/if this still can happen. Need to go through all places where we create a DkimRecord in the db, and make sure it cannot create duplicated. In these screenshots, it says "Key origin: Reverse engineered", which might be a clue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: merges records with the same values hhuntaa/archive.prove.email
3 participants
@foolo @Divide-By-0 @hhuntaa