Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Issue with lua-resty-openidc and lua-resty-session #487

Closed
NizanHellman opened this issue Aug 8, 2023 · 1 comment
Closed

Comments

@NizanHellman
Copy link

I'm facing compatibility issues while using lua-resty-openidc version 1.7.5 with lua-resty-session. The issue seems to be related to the deprecation of the session.present attribute in the latest version of lua-resty-session. I'm using OpenResty version 1.21.4.2-0-jammy.

Environment
  • lua-resty-openidc version: 1.7.5
  • lua-resty-session version: (latest version where session.present was deprecated)
  • OpenResty version: 1.21.4.2-0-jammy
Expected behaviour

I expected that using lua-resty-openidc 1.7.5 along with the latest version of lua-resty-session in OpenResty 1.21.4.2-0-jammy would work without any compatibility issues.

Actual behaviour

When using lua-resty-openidc 1.7.5 with the latest lua-resty-session, I encountered compatibility issues due to the deprecated session.present attribute in the latest lua-resty-session version.

Minimized example

Steps to Reproduce:

  1. Install lua-resty-openidc v1.7.5
  2. Use it in conjunction with lua-resty-session (latest)
  3. Observe the compatibility issue due to the deprecated session.present attribute.
@bodewig
Copy link
Collaborator

bodewig commented Aug 8, 2023

This is a know issue, lua-resty-openidc does not work with lua-resty-session 4.x - and the luarocks spec of 1.7.6 explicitly requires lua-resty-session 2 or 3. See #480

#478 is an initial attempt to make lua-resty-openidc work with lua-resty-session but it turns out to have issues of its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants