-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update soft-off.md #2299
base: main
Are you sure you want to change the base?
Update soft-off.md #2299
Conversation
Adding Split Peripheral Off On Press
I'd like to understand why this setting was implemented and defaulted to first, before encouraging people to turn them off. @petejohanson can you elaborate? |
I think it's related to the issue I reported today #2300 |
I guess I'm confused when you'd ever want to only put the central side into soft off, that you'd need this documented? |
While fixing the peripheral soft_off issue, I noted that the peripheral turned off as soon as I pressed the key, despite the hold-time-ms setting. Upon investigation, I discovered an undocumented option (possibly a workaround for the issue I reported in #2300). After disabling it, I encountered the aforementioned issue. I am unsure of the original author's intent with this option and can only speculate; therefore, I refrained from modifying it. Instead, I documented it and demonstrated what can be done if you prefer to disable it. |
The way the docs for From what I'm reading here, how it actually works is that when you press the button, part of the keyboard totally ignores your settings and goes into soft-off immediately. My presumption was (is) that the primary reason |
I agree with this part, but I still haven't figured out why |
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: Less/Rikki <[email protected]>
I was struggling to make soft_off work on my split, until I found this. First I tried a combo but it only worked on the central side, so I put a
Adding the fix in this PR makes both sides to shut off after the configured |
Adding Split Peripheral Off On Press basic documentation.