From fb4e3f64d1c3f2dbe12586d3516f9657230e9ca5 Mon Sep 17 00:00:00 2001 From: Samuel Date: Tue, 24 Dec 2024 19:15:13 -0300 Subject: [PATCH] Fix deadlock in release builds (#571) --- CHANGELOG.md | 1 + crates/zng-var/src/util.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0dc75b74d1..4264de1393 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ # Unreleased +* Fix deadlock in release builds (introduced in 0.13.1). # 0.13.1 diff --git a/crates/zng-var/src/util.rs b/crates/zng-var/src/util.rs index 651c35157e..426a950bef 100644 --- a/crates/zng-var/src/util.rs +++ b/crates/zng-var/src/util.rs @@ -491,6 +491,7 @@ fn apply_modify(inner: &RwLock>, modify: impl FnOnc let mut value = VarModify::new(&meta.value); modify(&mut value); let (notify, new_value, update, tags, custom_importance) = value.finish(); + drop(meta); // code size optimization, removes the impl FnOnce generic fn finish(