Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDataManager should not specify a transaction_manager attribute #47

Open
jimfulton opened this issue Mar 17, 2017 · 3 comments
Open

IDataManager should not specify a transaction_manager attribute #47

jimfulton opened this issue Mar 17, 2017 · 3 comments
Labels
bug enhancement

Comments

@jimfulton
Copy link
Member

It's not used by the transaction package and none of its concern.
@jimfulton
Copy link
Member Author

I noticed this while implementing a data manager for which this attribute makes no sense.

@jenstroeger
Copy link

Agreed, I’ve deleted the tm reference from two IDataManager implementations. Other than a code-smell, I can’t think of a scenario where a data manager would need a back-reference to the owning tm.

@d-maurer
Copy link
Contributor

d-maurer commented May 2, 2019 •
edited by icemac
Loading

@jimfulton

I noticed this while implementing a data manager for which this attribute makes no sense.

How does your "data manager" determines the "current transaction" to potentially join it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jimfulton @jamadden @d-maurer @jenstroeger