Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation is broken for typeless base profiles #2302

Open
t1m0thyj opened this issue Oct 10, 2024 · 2 comments
Open

Schema validation is broken for typeless base profiles #2302

t1m0thyj opened this issue Oct 10, 2024 · 2 comments
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Oct 10, 2024

Describe the bug

When using a typeless profile as a base profile and storing tokenValue as a secure field, then schema validation fails.

Expected and actual results

Since typeless profiles are often used as base profiles, I would expect that tokenValue property is supported in them.

For typeless profiles, the first item in the schema array definition gets used which is currently zosmf. We could fix this by re-ordering the schema array to put base profiles first, but will need to consider the impacts of this change.

Describe your environment

Schema created by Zowe CLI v8.0.1
Config edited in VS Code 1.94.1

Additional context

image

@t1m0thyj t1m0thyj added bug Something isn't working new The issue wasn't triaged yet labels Oct 10, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad Oct 10, 2024
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@awharn awharn added priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases and removed new The issue wasn't triaged yet labels Oct 16, 2024
@zowe-robot zowe-robot moved this from New Issues to Low Priority in Zowe CLI Squad Oct 16, 2024
@t1m0thyj
Copy link
Member Author

If we switch the order, this may break other properties defined in a typeless profile such as encoding.
Ideally IntelliSense for typeless profiles could show all properties available across all profiles, but this might cause conflicts if multiple profiles define the same property (e.g. zosmf user vs zftp user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases
Projects
Status: Low Priority
Development

No branches or pull requests

2 participants