Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Port profiles and import fixes #2377

Open
wants to merge 6 commits into
base: zowe-v2-lts
Choose a base branch
from
Open

Conversation

t1m0thyj
Copy link
Member

What It Does

Ports misc fixes from the main branch:

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.25%. Comparing base (08e02ce) to head (11b281f).

Files with missing lines Patch % Lines
...es/imperative/src/config/src/ProfileCredentials.ts 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v2-lts    #2377   +/-   ##
============================================
  Coverage        91.25%   91.25%           
============================================
  Files              638      638           
  Lines            19162    19168    +6     
  Branches          4062     4064    +2     
============================================
+ Hits             17486    17492    +6     
  Misses            1675     1675           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj marked this pull request as ready for review November 26, 2024 13:33
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the typos and refactoring the profiles logic 😋 Had a suggestion for updating an if/else block, but aside from that everything LGTM

Comment on lines +67 to +71
"@typescript-eslint/no-restricted-imports": ["error", {
"patterns": [{
"group": ["**/../lib", "**/../src"]
}]
}],
Copy link
Member

@traeok traeok Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lint rule seems really useful - would be nice to use this in Zowe Explorer & ZE API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

2 participants