-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: Port profiles and import fixes #2377
base: zowe-v2-lts
Are you sure you want to change the base?
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
505be93
to
7d8781d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## zowe-v2-lts #2377 +/- ##
============================================
Coverage 91.25% 91.25%
============================================
Files 638 638
Lines 19162 19168 +6
Branches 4062 4064 +2
============================================
+ Hits 17486 17492 +6
Misses 1675 1675
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the typos and refactoring the profiles logic 😋 Had a suggestion for updating an if/else block, but aside from that everything LGTM
"@typescript-eslint/no-restricted-imports": ["error", { | ||
"patterns": [{ | ||
"group": ["**/../lib", "**/../src"] | ||
}] | ||
}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lint rule seems really useful - would be nice to use this in Zowe Explorer & ZE API
What It Does
Ports misc fixes from the main branch:
How to Test
Review Checklist
I certify that I have:
Additional Comments