support auto exhaustive

Author: zth

compiler/crates/relay-transforms/src/validations/validate_exhaustive_directive.rs

@@ -380,6 +380,16 @@ impl<'schema, 'program, 'pc> ExhaustiveDirectiveValidator<'schema, 'program, 'pc
             .named(*NON_EXHAUSTIVE_DIRECTIVE_NAME)
             .is_some();
 
+        // Determine the type against which to validate coverage.
+        let target_type = if let Some(type_condition) = inline_fragment.type_condition {
+            type_condition
+        } else if let Some(parent_type) = self.parent_type {
+            parent_type
+        } else {
+            // Should not happen in practice, but bail out safely.
+            return;
+        };
+
         if let Some(directive) = inline_fragment.directives.named(*EXHAUSTIVE_DIRECTIVE_NAME) {
             has_directive = true;
             let (parsed_ignored, parsed_disabled) =
@@ -388,22 +398,14 @@ impl<'schema, 'program, 'pc> ExhaustiveDirectiveValidator<'schema, 'program, 'pc
             disabled = parsed_disabled;
         } else if has_non_exhaustive {
             return;
+        } else if self.type_is_auto_exhaustive(target_type) {
+            has_directive = true;
         }
 
         if !has_directive || disabled {
             return;
         }
 
-        // Determine the type against which to validate coverage.
-        let target_type = if let Some(type_condition) = inline_fragment.type_condition {
-            type_condition
-        } else if let Some(parent_type) = self.parent_type {
-            parent_type
-        } else {
-            // Should not happen in practice, but bail out safely.
-            return;
-        };
-
         let (missing_members, type_description) = match target_type {
             Type::Union(id) => (
                 self.check_exhaustive_union_coverage(id, &ignored, |object_id| {

compiler/crates/relay-transforms/tests/validate_exhaustive_directive.rs

@@ -13,7 +13,9 @@ use relay_transforms::validate_exhaustive_directive;
 
 pub async fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String> {
     apply_transform_for_test(fixture, |program| {
-        let auto_exhaustive_types = if fixture.file_name.contains("auto-type") {
+        let auto_exhaustive_types = if fixture.file_name.contains("auto-type")
+            || fixture.file_name.contains("inline-fragment-auto-type")
+        {
             vec!["UserNameRenderer".intern()]
         } else {
             vec![]

compiler/crates/relay-transforms/tests/validate_exhaustive_directive/fixtures/inline-fragment-auto-type-missing.invalid.expected

@@ -0,0 +1,20 @@
+==================================== INPUT ====================================
+#expected-to-throw
+query InlineFragmentAutoTypeMissing {
+  me {
+    nameRenderer @nonExhaustive {
+      ... {
+        ... on PlainUserNameRenderer { __typename }
+        ... on MarkdownUserNameRenderer { __typename }
+      }
+    }
+  }
+}
+==================================== ERROR ====================================
+✖︎ Inline fragment marked with @exhaustive is missing selection for union members: 'CustomNameRenderer'.
+
+  inline-fragment-auto-type-missing.invalid.graphql:5:7
+    4 │     nameRenderer @nonExhaustive {
+    5 │       ... {
+      │       ^^^
+    6 │         ... on PlainUserNameRenderer { __typename }

compiler/crates/relay-transforms/tests/validate_exhaustive_directive/fixtures/inline-fragment-auto-type-missing.invalid.graphql

@@ -0,0 +1,11 @@
+#expected-to-throw
+query InlineFragmentAutoTypeMissing {
+  me {
+    nameRenderer @nonExhaustive {
+      ... {
+        ... on PlainUserNameRenderer { __typename }
+        ... on MarkdownUserNameRenderer { __typename }
+      }
+    }
+  }
+}

compiler/crates/relay-transforms/tests/validate_exhaustive_directive/fixtures/inline-fragment-with-alias-exhaustive.expected

@@ -0,0 +1,30 @@
+==================================== INPUT ====================================
+query InlineFragmentWithAliasExhaustive {
+  me {
+    nameRenderer {
+      ... @alias(as: "widget") @exhaustive {
+        ... on PlainUserNameRenderer { __typename }
+        ... on MarkdownUserNameRenderer { __typename }
+        ... on CustomNameRenderer { __typename }
+      }
+    }
+  }
+}
+==================================== OUTPUT ===================================
+query InlineFragmentWithAliasExhaustive {
+  me {
+    nameRenderer {
+      ... @alias(as: "widget") @exhaustive {
+        ... on PlainUserNameRenderer {
+          __typename
+        }
+        ... on MarkdownUserNameRenderer {
+          __typename
+        }
+        ... on CustomNameRenderer {
+          __typename
+        }
+      }
+    }
+  }
+}

compiler/crates/relay-transforms/tests/validate_exhaustive_directive/fixtures/inline-fragment-with-alias-exhaustive.graphql

@@ -0,0 +1,12 @@
+query InlineFragmentWithAliasExhaustive {
+  me {
+    nameRenderer {
+      ... @alias(as: "widget") @exhaustive {
+        ... on PlainUserNameRenderer { __typename }
+        ... on MarkdownUserNameRenderer { __typename }
+        ... on CustomNameRenderer { __typename }
+      }
+    }
+  }
+}
+

compiler/crates/relay-transforms/tests/validate_exhaustive_directive_test.rs

@@ -189,6 +189,25 @@ async fn interface_all_members_valid() {
     .await;
 }
 
+#[tokio::test]
+async fn inline_fragment_with_alias_exhaustive() {
+    let input = include_str!(
+        "validate_exhaustive_directive/fixtures/inline-fragment-with-alias-exhaustive.graphql"
+    );
+    let expected = include_str!(
+        "validate_exhaustive_directive/fixtures/inline-fragment-with-alias-exhaustive.expected"
+    );
+    test_fixture(
+        transform_fixture,
+        file!(),
+        "inline-fragment-with-alias-exhaustive.graphql",
+        "validate_exhaustive_directive/fixtures/inline-fragment-with-alias-exhaustive.expected",
+        input,
+        expected,
+    )
+    .await;
+}
+
 #[tokio::test]
 async fn interface_missing_member() {
     let input = include_str!(
@@ -245,3 +264,22 @@ async fn inline_fragment_missing_member() {
     )
     .await;
 }
+
+#[tokio::test]
+async fn inline_fragment_auto_type_missing() {
+    let input = include_str!(
+        "validate_exhaustive_directive/fixtures/inline-fragment-auto-type-missing.invalid.graphql"
+    );
+    let expected = include_str!(
+        "validate_exhaustive_directive/fixtures/inline-fragment-auto-type-missing.invalid.expected"
+    );
+    test_fixture(
+        transform_fixture,
+        file!(),
+        "inline-fragment-auto-type-missing.invalid.graphql",
+        "validate_exhaustive_directive/fixtures/inline-fragment-auto-type-missing.invalid.expected",
+        input,
+        expected,
+    )
+    .await;
+}