link_utils: exposing whitelisted protocols to user settings

Adding config option to set protocols in the config that are whitelisted
to be opened directly. The behaviour is documented in docs\howto\customize-link-protocols.md.

translations: Update translations from Transifex.

Signed-off-by: Anders Kaseorg <[email protected]>

Switch i18next-scanner to i18next-parser.

Signed-off-by: Anders Kaseorg <[email protected]>

Switch to "type": "module".

Signed-off-by: Anders Kaseorg <[email protected]>

index: Avoid deprecated Buffer#slice.

Signed-off-by: Anders Kaseorg <[email protected]>

xo: Fix unicorn/prefer-single-call.

Signed-off-by: Anders Kaseorg <[email protected]>

xo: Fix unicorn/prefer-string-raw.

Signed-off-by: Anders Kaseorg <[email protected]>

xo: Fix @typescript-eslint/prefer-nullish-coalescing.

Signed-off-by: Anders Kaseorg <[email protected]>

webview: Adjust app.dock feature test for TypeScript friendliness.

Signed-off-by: Anders Kaseorg <[email protected]>

stylelint: Fix property-no-deprecated.

Signed-off-by: Anders Kaseorg <[email protected]>

Upgrade dependencies, including Electron 37.2.5.

Signed-off-by: Anders Kaseorg <[email protected]>

Focus the webview for notification settings, keyboard shortcuts.

Signed-off-by: Anders Kaseorg <[email protected]>

workflows: Use actions/setup-node.

Signed-off-by: Anders Kaseorg <[email protected]>

Convert i18next-parser configuration to TypeScript.

Signed-off-by: Anders Kaseorg <[email protected]>

tests: Switch from medium to p-fifo.

Signed-off-by: Anders Kaseorg <[email protected]>

tests: Convert tests to TypeScript.

Signed-off-by: Anders Kaseorg <[email protected]>

tests: Move tests/package.json to its own folder.

Signed-off-by: Anders Kaseorg <[email protected]>

Correct node-json-db Errors.js imports.

Signed-off-by: Anders Kaseorg <[email protected]>

Mark more strings for translation.

Fixes #1128 among many other things.

Signed-off-by: Anders Kaseorg <[email protected]>

Update apt signing key with SHA-256 binding signatures.

Fixes #1437.

Signed-off-by: Anders Kaseorg <[email protected]>

Author: jonassorgenfrei

.github/workflows/node.js.yml

@@ -10,6 +10,9 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
       - uses: actions/checkout@v4
       - run: npm ci
       - run: npm test

.npmrc

@@ -0,0 +1 @@
+node-options=--experimental-strip-types

app/common/config-schemata.ts

@@ -36,6 +36,7 @@ export const configSchemata = {
   useManualProxy: z.boolean(),
   useProxy: z.boolean(),
   useSystemProxy: z.boolean(),
+  whitelistedProtocols: z.string().array(),
 };
 
 export const enterpriseConfigSchemata = {

app/common/config-util.ts

@@ -3,7 +3,7 @@ import path from "node:path";
 
 import * as Sentry from "@sentry/core";
 import {JsonDB} from "node-json-db";
-import {DataError} from "node-json-db/dist/lib/Errors";
+import {DataError} from "node-json-db/dist/lib/Errors.js";
 import type {z} from "zod";
 import {app, dialog} from "zulip:remote";
 

app/common/enterprise-util.ts

@@ -26,8 +26,7 @@ reloadDatabase();
 function reloadDatabase(): void {
   let enterpriseFile = "/etc/zulip-desktop-config/global_config.json";
   if (process.platform === "win32") {
-    enterpriseFile =
-      "C:\\Program Files\\Zulip-Desktop-Config\\global_config.json";
+    enterpriseFile = String.raw`C:\Program Files\Zulip-Desktop-Config\global_config.json`;
   }
 
   enterpriseFile = path.resolve(enterpriseFile);

app/common/link-util.ts

@@ -3,10 +3,22 @@ import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
 
-import {html} from "./html.ts";
+import * as ConfigUtil from "./config-util.ts";
+import {Html, html} from "./html.ts";
+import * as t from "./translation-util.ts";
+
+
+/* Fetches the current protocolLaunchers from settings.json */
+const whitelistedProtocols = ConfigUtil.getConfigItem("whitelistedProtocols", [
+  "http:",
+  "https:",
+  "mailto:",
+  "tel:",
+  "sip:",
+]);
 
 export async function openBrowser(url: URL): Promise<void> {
-  if (["http:", "https:", "mailto:"].includes(url.protocol)) {
+  if (whitelistedProtocols.includes(url.protocol)) {
     await shell.openExternal(url.href);
   } else {
     // For security, indirect links to non-whitelisted protocols
@@ -21,15 +33,21 @@ export async function openBrowser(url: URL): Promise<void> {
           <head>
             <meta charset="UTF-8" />
             <meta http-equiv="Refresh" content="0; url=${url.href}" />
-            <title>Redirecting</title>
+            <title>${t.__("Redirecting")}</title>
             <style>
               html {
                 font-family: menu, "Helvetica Neue", sans-serif;
               }
             </style>
           </head>
           <body>
-            <p>Opening <a href="${url.href}">${url.href}</a>…</p>
+            <p>
+              ${new Html({
+                html: t.__("Opening {{{link}}}…", {
+                  link: html`<a href="${url.href}">${url.href}</a>`.html,
+                }),
+              })}
+            </p>
           </body>
         </html>
       `.html,

app/common/messages.ts

@@ -1,3 +1,5 @@
+import * as t from "./translation-util.ts";
+
 type DialogBoxError = {
   title: string;
   content: string;
@@ -13,26 +15,24 @@ export function invalidZulipServerError(domain: string): string {
  https://zulip.readthedocs.io/en/stable/production/ssl-certificates.html`;
 }
 
-export function enterpriseOrgError(
-  length: number,
-  domains: string[],
-): DialogBoxError {
+export function enterpriseOrgError(domains: string[]): DialogBoxError {
   let domainList = "";
   for (const domain of domains) {
     domainList += `• ${domain}\n`;
   }
 
   return {
-    title: `Could not add the following ${
-      length === 1 ? "organization" : "organizations"
-    }`,
-    content: `${domainList}\nPlease contact your system administrator.`,
+    title: t.__mf(
+      "{number, plural, one {Could not add # organization} other {Could not add # organizations}}",
+      {number: domains.length},
+    ),
+    content: `${domainList}\n${t.__("Please contact your system administrator.")}`,
   };
 }
 
 export function orgRemovalError(url: string): DialogBoxError {
   return {
-    title: `Removing ${url} is a restricted operation.`,
-    content: "Please contact your system administrator.",
+    title: t.__("Removing {{{url}}} is a restricted operation.", {url}),
+    content: t.__("Please contact your system administrator."),
   };
 }

app/common/translation-util.ts

@@ -13,4 +13,4 @@ i18n.configure({
 /* Fetches the current appLocale from settings.json */
 i18n.setLocale(ConfigUtil.getConfigItem("appLanguage", "en") ?? "en");
 
-export {__} from "i18n";
+export {__, __mf} from "i18n";

app/main/handle-external-link.ts

@@ -11,6 +11,7 @@ import path from "node:path";
 
 import * as ConfigUtil from "../common/config-util.ts";
 import * as LinkUtil from "../common/link-util.ts";
+import * as t from "../common/translation-util.ts";
 
 import {send} from "./typed-ipc-main.ts";
 
@@ -125,8 +126,8 @@ export default function handleExternalLink(
       downloadPath,
       async completed(filePath: string, fileName: string) {
         const downloadNotification = new Notification({
-          title: "Download Complete",
-          body: `Click to show ${fileName} in folder`,
+          title: t.__("Download Complete"),
+          body: t.__("Click to show {{{fileName}}} in folder", {fileName}),
           silent: true, // We'll play our own sound - ding.ogg
         });
         downloadNotification.on("click", () => {
@@ -149,8 +150,8 @@ export default function handleExternalLink(
         if (state !== "cancelled") {
           if (ConfigUtil.getConfigItem("promptDownload", false)) {
             new Notification({
-              title: "Download Complete",
-              body: "Download failed",
+              title: t.__("Download Complete"),
+              body: t.__("Download failed"),
             }).show();
           } else {
             contents.downloadURL(url.href);

app/main/index.ts

@@ -32,7 +32,7 @@ import {sentryInit} from "./sentry.ts";
 import {setAutoLaunch} from "./startup.ts";
 import {ipcMain, send} from "./typed-ipc-main.ts";
 
-import "gatemaker/electron-setup"; // eslint-disable-line import/no-unassigned-import
+import "gatemaker/electron-setup.js"; // eslint-disable-line import-x/no-unassigned-import
 
 // eslint-disable-next-line @typescript-eslint/naming-convention
 const {GDK_BACKEND} = process.env;
@@ -87,7 +87,7 @@ function createMainWindow(): BrowserWindow {
     minWidth: 500,
     minHeight: 400,
     webPreferences: {
-      preload: path.join(bundlePath, "renderer.js"),
+      preload: path.join(bundlePath, "renderer.cjs"),
       sandbox: false,
       webviewTag: true,
     },
@@ -239,9 +239,9 @@ function createMainWindow(): BrowserWindow {
     try {
       // Check that the data on the clipboard was encrypted to the key.
       const data = Buffer.from(clipboard.readText(), "hex");
-      const iv = data.slice(0, 12);
-      const ciphertext = data.slice(12, -16);
-      const authTag = data.slice(-16);
+      const iv = data.subarray(0, 12);
+      const ciphertext = data.subarray(12, -16);
+      const authTag = data.subarray(-16);
       const decipher = crypto.createDecipheriv("aes-256-gcm", key, iv, {
         authTagLength: 16,
       });