Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce assumptions that scripts start outside Docker #13

Closed
zultron opened this issue Apr 9, 2015 · 4 comments
Closed

Reduce assumptions that scripts start outside Docker #13

zultron opened this issue Apr 9, 2015 · 4 comments

Comments

@zultron
Copy link
Owner

zultron commented Apr 9, 2015

Right now, the scripts mostly assume that they will be started in a shell outside Docker. This conflicts with at least these use cases:

  • A Buildbot setup, where the build slave starts scripts from within Docker
  • A boot2docker setup, where there is no external shell environment
@zultron
Copy link
Owner Author

zultron commented Apr 9, 2015

Probably related to 'Misc fixes #9', 'Refactor options: separate Docker, sbuild, dpkg and apt functions'.

@zultron
Copy link
Owner Author

zultron commented Apr 9, 2015

In fact, best would be to include the mk-dbuild scripts inside the Docker container, with the option to mount a dev tree from the host. Then the image could be hosted on the Docker registry with docs about various useful docker run commands. (Also related to above 'Refactor options' issue.)

@zultron
Copy link
Owner Author

zultron commented Apr 9, 2015

...And then the mk-debuild scripts could be used for a lot of the configuration in Dockerfile, which really should be tied into the config infra from the scripts.

@zultron
Copy link
Owner Author

zultron commented Apr 10, 2015

A bug in Docker versions before 1.1.1 prevents exit status being passed back from docker run -i -t. The top-level scripts therefore can't read exit status.

Not allocating a tty with -t fixes that problem, but then the command output is buffered, which is annoying when a human is watching.

The best fix, outside of waiting for 1.1.1 to come to a distro, is to stop running from outside Docker.

@zultron zultron closed this as completed in 3a1858d May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant