Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soundness issue #14

Open
Freax13 opened this issue Aug 28, 2021 · 0 comments
Open

Soundness issue #14

Freax13 opened this issue Aug 28, 2021 · 0 comments

Comments

@Freax13
Copy link

Freax13 commented Aug 28, 2021

ModbusMapping::get_bits, ModbusMapping::get_bits_mut, ModbusMapping::get_input_bits, ModbusMapping::get_input_bits_mut, ModbusMapping::get_input_registers, ModbusMapping::get_input_registers_mut, ModbusMapping::get_registers and ModbusMapping::get_registers_mut dereference the user accessible raw pointer ModbusMapping::modbus_mapping.

This is unsound because a user could safely modify ModbusMapping::modbus_mapping and call one of the methods listed above to cause UB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Freax13