fix : restore wsgi.input stream after middleware body read so request.get_json() works in views - #201
Open
0x070907 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #185
The fix reads environ["wsgi.input"] directly before Request(environ) is called, then immediately restores it with a fresh BytesIO. Flask's Request then wraps the restored stream and request.get_json() works correctly.
Why
Any Flask view that calls request.get_json() or request.get_data(), after the middleware ran, would silently receive an empty body. The bug was hidden in existing tests because no test view ever read the request body.
Scope
Changes
adiuvare/integrations/flask.py- Addedimport io, moved body reading before Request(environ), restored wsgi.input with BytesIOtests/test_flask.py- Added test_flask_request_json_readable_after_middleware_inspectionVerification
Commands run:
pip install -e . pytest tests/test_flask.py::test_flask_request_json_readable_after_middleware_inspection -vScreenshots
before the fix
after the fix
Notes:
Signal-specific notes
TUI notes
Local-only file check
adiuvare.yamlor localconftest.pychanges