Skip to content

tui: Make verdict colors and badges more consistent across operator screens - #78

Open
KaayanatSally wants to merge 12 commits into
0-Shimanshu:mainfrom
KaayanatSally:fix/tui-verdict-consistency
Open

tui: Make verdict colors and badges more consistent across operator screens#78
KaayanatSally wants to merge 12 commits into
0-Shimanshu:mainfrom
KaayanatSally:fix/tui-verdict-consistency

Conversation

@KaayanatSally

@KaayanatSally KaayanatSally commented May 16, 2026

Copy link
Copy Markdown

Summary

This PR improves verdict consistency across the TUI operator screens.

Changes made:

Added shared render_decision_badge() helper for centralized verdict rendering
Reused shared verdict badge rendering in Events and Audit screens
Updated AI screen verdict terminology for consistency
Improved visual distinction for throttle using the purple palette color
Reduced duplicated verdict formatting logic across screens

Why

Verdict categories such as allow, flag, throttle, and block
were rendered inconsistently across different TUI views.

This change improves operator readability by ensuring verdicts use a
consistent visual language across Monitor, Events, Audit, and AI screens
without changing scoring or decision semantics.

Scope

What kind of change is this?
[ ] TUI / CLI improvement

Verification

How did you verify the change?

Commands run:

TUI verified manually during development

Notes:

  • I updated screenshots if the TUI changed materially

Signal-specific notes

If this PR adds or changes a signal or a meaningful detection pattern, fill this in.

Signal type:

  • not applicable

Source, reproducer, or proof:

Benign case checked:

Performance note:

TUI notes

  • before/after screenshots attached

Local-only file check

I did not accidentally stage local-only files such as adiuvare.yaml or local conftest.py changes

Related issue

Closes #20
Attached screenshots show the verdict rendering consistency updates across the affected TUI screens.
image (10)
image (9)
image (8)
image (7)
image (6)

Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
@github-actions github-actions Bot added the enhancement New feature or request label May 16, 2026
@0-Shimanshu

Copy link
Copy Markdown
Owner

The idea looks good, but the PR is not ready yet because Ruff is failing.

After adding render_decision_badge(), some old variables are still left in the code but are no longer used.

Please remove the unused variables Ruff is pointing to:

  • icon in adiuvare/tui/screens/ai.py
  • icon, color, verdict_color in adiuvare/tui/screens/audit.py
  • icon, color, verdict_color in adiuvare/tui/screens/events.py

Also add a blank line between decision_icon() and decision_label() in adiuvare/tui/workspace.py.

Once the lint check is green, this should be good to review again.

and add ss of the tui before and after since its a tui pr

Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
@0-Shimanshu

Copy link
Copy Markdown
Owner

@KaayanatSally

1 similar comment
@0-Shimanshu

Copy link
Copy Markdown
Owner

@KaayanatSally

Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
Signed-off-by: KaayanatSally <kaayanatsally@gmail.com>
@0-Shimanshu

Copy link
Copy Markdown
Owner

@KaayanatSally i wouls need to see ss of the tui screen where the changes are made not the code area that i can already see in the commit changes

@0-Shimanshu

Copy link
Copy Markdown
Owner

@KaayanatSally update?

@KaayanatSally

Copy link
Copy Markdown
Author

Thanks for the review. I was away for a few days and just got back to this PR.
I've addressed the Ruff issues and test failures. The remaining failing check is the repository hygiene test-update requirement.
Regarding the screenshots, I currently don't have a local environment set up to capture the TUI screens. Would code-diff screenshots be sufficient for this visual-consistency change, or would you prefer that I set up the TUI locally and provide actual before/after screen captures?

@0-Shimanshu

Copy link
Copy Markdown
Owner

@KaayanatSally tui ss are required too see what changed
i suppose u would have cloned the repo offline and runned it to make those changes so you should be able to run it locally.

@KaayanatSally

KaayanatSally commented Jun 11, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tui: make verdict colors and badges more consistent across operator screens

2 participants