Skip to content

fix: include replit.tcss in package data - #93

Merged
0-Shimanshu merged 1 commit into
0-Shimanshu:mainfrom
0x070907:fix/tui-tcss-packaging
May 17, 2026
Merged

fix: include replit.tcss in package data #93
0-Shimanshu merged 1 commit into
0-Shimanshu:mainfrom
0x070907:fix/tui-tcss-packaging

Conversation

@0x070907

@0x070907 0x070907 commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

adiuvare/tui/replit.tcss was present in the source tree but not declared in pyproject.toml or MANIFEST.in, so it was silently dropped from non-editable installs.

Why

adv crashed immediately with StylesheetError: unable to read CSS file replit.tcss for anyone who installed via pip install . or
pip install git+https://github.com/0-Shimanshu/ADIUVARE. The TUI was completely unusable outside of editable installs.

Scope

  • bug fix
  • documentation
  • tests
  • TUI / CLI improvement
  • framework integration
  • signal change
  • configuration or route-policy change

Verification

Commands run:

pip install . --target ./adv-verify           # install into isolated target directory (not source tree)

# verify tcss is present in the installed package
python -c "
import pathlib
tcss = list(pathlib.Path('./adv-verify/adiuvare/tui').glob('*.tcss'))
assert tcss, 'replit.tcss missing from installed package!'
print('OK — found:', [f.name for f in tcss])
"
image
 adv # confirmed adv opens TUI successfully after pip install .
image

Notes:

  • I ran the relevant tests locally
  • I updated docs if behavior changed
  • I updated screenshots if the TUI changed materially

Signal-specific notes

If this PR adds or changes a signal or a meaningful detection pattern, fill this in.

Signal type:

  • hard signal (trackA)
  • soft signal (trackB)
  • not applicable

TUI notes

If this PR changes the TUI, include before/after screenshots or a short capture.

  • before/after screenshots attached
  • not applicable

Local-only file check

  • I did not accidentally stage local-only files such as adiuvare.yaml or local conftest.py changes

Related issue

Closes #91

@0x070907

0x070907 commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

Please merge #71 and this pr, else install sqlalchemy explicitly,so that the app doesn't crash due to #67 during non-editable installs.

@0-Shimanshu

Copy link
Copy Markdown
Owner

This looks good to me. replit.tcss is loaded by the TUI at runtime, so it needs to be included in normal package installs, not just editable source checkouts. Adding it to both MANIFEST.in and tool.setuptools.package-data is the right shape, and the install-target verification is the right kind of proof here. From my side, this is good to take.

@0-Shimanshu 0-Shimanshu added level:beginner GSSoC difficulty: beginner quality:clean GSSoC quality: clean implementation type:bug GSSoC type bonus: bug fix gssoc:approved GSSoC validation: approved labels May 17, 2026
@0-Shimanshu
0-Shimanshu merged commit cb2523a into 0-Shimanshu:main May 17, 2026
11 checks passed
@0x070907

0x070907 commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

This looks good to me. replit.tcss is loaded by the TUI at runtime, so it needs to be included in normal package installs, not just editable source checkouts. Adding it to both MANIFEST.in and tool.setuptools.package-data is the right shape, and the install-target verification is the right kind of proof here. From my side, this is good to take.

Glad you liked my work, thanks for merging! Kindly check pr #71 as well

@0x070907
0x070907 deleted the fix/tui-tcss-packaging branch May 18, 2026 04:21
@0-Shimanshu 0-Shimanshu added the GSSOC_2026_contributor it is a symbol your contribution was accepted and recognised label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gssoc:approved GSSoC validation: approved GSSOC_2026_contributor it is a symbol your contribution was accepted and recognised level:beginner GSSoC difficulty: beginner quality:clean GSSoC quality: clean implementation type:bug GSSoC type bonus: bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: adv crashes on launch — replit.tcss not included in installed package

2 participants