You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
adiuvare/tui/replit.tcss was present in the source tree but not declared in pyproject.toml or MANIFEST.in, so it was silently dropped from non-editable installs.
Why
adv crashed immediately with StylesheetError: unable to read CSS file replit.tcss for anyone who installed via pip install . or pip install git+https://github.com/0-Shimanshu/ADIUVARE. The TUI was completely unusable outside of editable installs.
Scope
bug fix
documentation
tests
TUI / CLI improvement
framework integration
signal change
configuration or route-policy change
Verification
Commands run:
pip install . --target ./adv-verify # install into isolated target directory (not source tree)# verify tcss is present in the installed package
python -c "import pathlibtcss = list(pathlib.Path('./adv-verify/adiuvare/tui').glob('*.tcss'))assert tcss, 'replit.tcss missing from installed package!'print('OK — found:', [f.name for f in tcss])"
This looks good to me. replit.tcss is loaded by the TUI at runtime, so it needs to be included in normal package installs, not just editable source checkouts. Adding it to both MANIFEST.in and tool.setuptools.package-data is the right shape, and the install-target verification is the right kind of proof here. From my side, this is good to take.
This looks good to me. replit.tcss is loaded by the TUI at runtime, so it needs to be included in normal package installs, not just editable source checkouts. Adding it to both MANIFEST.in and tool.setuptools.package-data is the right shape, and the install-target verification is the right kind of proof here. From my side, this is good to take.
Glad you liked my work, thanks for merging! Kindly check pr #71 as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adiuvare/tui/replit.tcsswas present in the source tree but not declared inpyproject.tomlorMANIFEST.in, so it was silently dropped from non-editable installs.Why
advcrashed immediately withStylesheetError: unable to read CSS file replit.tcssfor anyone who installed viapip install .orpip install git+https://github.com/0-Shimanshu/ADIUVARE. The TUI was completely unusable outside of editable installs.Scope
Verification
Commands run:
adv # confirmed adv opens TUI successfully after pip install .Notes:
Signal-specific notes
If this PR adds or changes a signal or a meaningful detection pattern, fill this in.
Signal type:
trackA)trackB)TUI notes
If this PR changes the TUI, include before/after screenshots or a short capture.
Local-only file check
adiuvare.yamlor localconftest.pychangesRelated issue
Closes #91