Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-3265 Fix rust piscine's quest-03 #146

Merged
merged 34 commits into from
Jan 29, 2025
Merged

CON-3265 Fix rust piscine's quest-03 #146

merged 34 commits into from
Jan 29, 2025
+441 −1,251

Conversation

pedrodesu
Copy link
Contributor

@pedrodesu pedrodesu commented Dec 26, 2024 •
edited by jira bot
Loading

Pedro Ferreira added 30 commits December 10, 2024 13:27
fix(borrow): changed exercise
2597a93
fix(doubtful): changed exercise
472b6bb
fix(to_url): changed exercise
60bbf88
fix(string_literals): changed exercise
da63ae5
fix(string_literals): changed exercise
6b50cdb
fix(name_initials): changed exercise
fda8a25
fix(ownership): changed exercise
ac663fc
fix(copy): changed exercise
a53b8d2
fix(borrow_me_the_reference): changed exercise
4f794f2
fix(tic_tac_toe): changed exercise
1cf688a
fix(arrange_it): changed exercise, also refactored the CounterAlloc f…
90f0384 
…or two other exercises
fix(armstrong_number): changed exercise
3a741d5
fix(dockerfile): bump rust to
da7d8ce
fix(quest-02): reverted all editions to 2021
1fae605
fix(copy): small change to avoid an extra allocation
c58f17a
fix(armstrong_number): minor change
3fce2ff
fix(copy): another allocation removed
55b68f8
fix(tic_tac_toe): minor idiomatic changes
477b8ea
fix(changes)
8f3ef1e
fix(circle)
a73e037
fix(card_deck)
cd094a0
fix(arrays)
4ee6254
rm(strings)
39a45fb
fix(capitalizing)
02a4a1d
fix(edit_distance)
57fe9b9
fix(simple_hash)
55ba7de
fix(bigger)
517ad08
fix(string_permutation)
01889f2
fix(hashing)
e598e63
fix(collect)
35a385b
@pedrodesu pedrodesu added the enhancement New feature or request label Dec 26, 2024
@pedrodesu pedrodesu requested a review from MSilva95 December 26, 2024 14:49
@pedrodesu pedrodesu self-assigned this Dec 26, 2024
MSilva95
MSilva95 requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the exercises "is_anagram" and "strings" to be removed?

@pedrodesu
Copy link
Contributor Author

They are. That's deliberate. Though I'm not sure if just removing them from the /rust-tests repository would be sufficient/wouldn't break anything else in current content versions.

MSilva95
MSilva95 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrodesu pedrodesu merged commit b04d705 into master Jan 29, 2025
2 checks passed
@pedrodesu pedrodesu deleted the CON-3265-fix-rust-quest-03 branch January 29, 2025 11:46
@pedrodesu pedrodesu restored the CON-3265-fix-rust-quest-03 branch January 30, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilva95 MSilva95

Assignees

@pedrodesu pedrodesu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pedrodesu @MSilva95