Add sync feature to make json::Val Sync+Send
#325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01mf02
reviewed
Sep 19, 2025
This allows moving it off the main thread, processing json in parallel and moving the results back to main.
I-Al-Istannen
force-pushed
the
feature/sync
branch
from
e92085f to
350838d
Compare
01mf02
reviewed
Sep 22, 2025
jaq-json/src/lib.rs
Outdated
| pub use funs::funs; | ||
| pub use num::Num; | ||
|
|
||
| #[cfg(feature = "sync")] |
There was a problem hiding this comment.
Can't we actually do pub(crate) use alloc::sync::Arc as Rc here and use Rc everywhere? That would make this PR much smaller ...
There was a problem hiding this comment.
If you are fine with it, I certainly can. I just did not want to lie about what Rc refers to, as many people have expectations when reading it :) If you want it though, I will gladly change it. I have no strong opinion.
There was a problem hiding this comment.
I did this change myself now in d5f4b84.
There was a problem hiding this comment.
Sounds good to me :)
|
Thanks again for your contribution! :) |
|
Thank you for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows moving it off the main thread, processing json in parallel and moving the results back to main.
I settled on
RefPtras it is quite short and a common name in other languages for reference counted pointers.