Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify client in download handler #1378

Merged
merged 19 commits into from
Feb 10, 2024
Merged

verify client in download handler #1378

merged 19 commits into from
Feb 10, 2024

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Jan 24, 2024

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (cce361c) 14.40% compared to head (9f54632) 14.46%.

Files Patch % Lines
...et/blobbercore/handler/object_operation_handler.go 44.00% 11 Missing and 3 partials ⚠️
.../0chain.net/blobbercore/handler/storage_handler.go 55.17% 11 Missing and 2 partials ⚠️
code/go/0chain.net/blobbercore/handler/context.go 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1378      +/-   ##
===========================================
+ Coverage    14.40%   14.46%   +0.06%     
===========================================
  Files          177      177              
  Lines        19859    19891      +32     
===========================================
+ Hits          2861     2878      +17     
- Misses       16642    16653      +11     
- Partials       356      360       +4     
Flag Coverage Δ
Unit-Tests 14.46% <56.92%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hitenjain14 Hitenjain14 changed the base branch from staging to sprint-1.12 February 4, 2024 21:13
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov changed the base branch from sprint-1.12 to staging February 10, 2024 18:59
@dabasov dabasov merged commit d1f396d into staging Feb 10, 2024
5 of 7 checks passed
@dabasov dabasov deleted the hotfix/download-sig branch February 10, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants