Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for max blobbers upto 40 #1563

Open
wants to merge 2 commits into
base: sprint-1.17
Choose a base branch
from

Conversation

pewssh
Copy link
Collaborator

@pewssh pewssh commented Jul 22, 2024

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@dabasov
Copy link
Member

dabasov commented Jul 25, 2024

why should we limit the amount of blobbers? most of the time we need to provide to allocation more blobbers than parity+data to eliminate the race condition

Copy link
Collaborator

@Jayashsatolia403 Jayashsatolia403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the way we are dealing with limit. Currently we are striclty passing 20 limit. We need to get more by setting offset if less than requirement is returned.

Copy link
Collaborator

@Jayashsatolia403 Jayashsatolia403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the way we are dealing with limit. Currently we are striclty passing 20 limit. We need to get more by setting offset if less than requirement is returned.

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk Fix/max_blobbers_newallocation
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants