Fix/refactor zboxcore and zcncore #1583
Open
+2,763
−20,549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/conf/vars.go # wasmsdk/proxy.go # zboxcore/blockchain/entity.go # zboxcore/client/entity.go # zboxcore/sdk/allocation_file_test.go # zboxcore/sdk/blockdownloadworker.go # zboxcore/sdk/chunked_upload.go # zboxcore/sdk/downloadworker.go # zboxcore/sdk/rollback.go # zboxcore/sdk/sdk.go # zboxcore/zboxutil/http.go # zcncore/networkworker.go # zcncore/networkworker_mobile.go # zcncore/transaction.go # zcncore/transaction_base.go # zcncore/wallet_base.go
Jayashsatolia403
requested review from
peterlimg,
dabasov and
guruhubb
as code owners
…refactor-zboxcore
…refactor-zboxcore
…boxcore # Conflicts: # mobilesdk/zcn/readpool.go # mobilesdk/zcn/smartcontract.go # zboxcore/sdk/blobber_operations.go # zboxcore/sdk/sdk.go # zboxcore/sdk/transaction.go # zcncore/transaction_mobile.go # zcncore/transactionauth_mobile.go
* fix: GetWalletBalance in mobilesdk. fix: include mobile build flags in execute_transactions.go fix: remove ignore package tag from transaction.go * fix: add GetUserLockedTotal. fix: InitSDK method while initializing storage SDK. fix: Conversion methods from ZCN to SAS. * fix: add proper conversions to WritePoolLock for tokens and fee. * fix: wasm build. * set toolcahin to go1.21.0 in znft/example. * Revert "set toolcahin to go1.21.0 in znft/example." This reverts commit 6ceea1a. * refactor: setup go 1.22 in build-sdks.yml for wasm builds. * refactor: setup go 1.22 in tests.yml for wasm tests. * nit fix build-sdks.yml wasm build. * nit fix build-sdks.yml wasm build. * nit fix build-sdks.yml wasm build. --------- Co-authored-by: Jayash Satolia <[email protected]>
* fix: GetWalletBalance in mobilesdk. fix: include mobile build flags in execute_transactions.go fix: remove ignore package tag from transaction.go * fix: add GetUserLockedTotal. fix: InitSDK method while initializing storage SDK. fix: Conversion methods from ZCN to SAS. * fix: add proper conversions to WritePoolLock for tokens and fee. * fix: wasm build. * set toolcahin to go1.21.0 in znft/example. * Revert "set toolcahin to go1.21.0 in znft/example." This reverts commit 6ceea1a. * refactor: setup go 1.22 in build-sdks.yml for wasm builds. * refactor: setup go 1.22 in tests.yml for wasm tests. * nit fix build-sdks.yml wasm build. * nit fix build-sdks.yml wasm build. * nit fix build-sdks.yml wasm build. * lint fixes. * fix: proofBurnTicket.go test --------- Co-authored-by: Jayash Satolia <[email protected]>
# Conflicts: # zboxapi/sdk.go # zboxapi/sdk_test.go
dabasov
requested changes
Sep 26, 2024
# Conflicts: # mobilesdk/zcn/smartcontract.go # zboxcore/sdk/transaction_mobile.go # zcncore/transaction.go # zcncore/transaction_base.go # zcncore/transaction_mobile.go # zcncore/transactionauth.go # zcncore/transactionauth_base.go # zcncore/transactionauth_mobile.go # zcncore/zauth.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):