Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multi wallet #1619

Merged
merged 12 commits into from
Oct 22, 2024
Merged

Feature/multi wallet #1619

merged 12 commits into from
Oct 22, 2024

Conversation

Jayashsatolia403
Copy link
Collaborator

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Conflicts:
#	core/client/set.go
#	zboxcore/sdk/allocation_test.go
#	zboxcore/sdk/sdk.go
#	zboxcore/zboxutil/http.go
#	zcncore/get_data.go
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Jayashsatolia403 and others added 6 commits October 19, 2024 21:03
# Conflicts:
#	zboxcore/sdk/allocation.go
#	zboxcore/sdk/chunked_upload_blobber.go
#	zboxcore/sdk/commitworker.go
#	zboxcore/sdk/filerefsworker.go
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 845c4ac into fix/refactor-zboxcore Oct 22, 2024
10 checks passed
@dabasov dabasov deleted the feature/multi-wallet branch October 22, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants