-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/refactor zboxcore mobilesdk fixes #1633
Open
yash10019coder
wants to merge
79
commits into
staging
Choose a base branch
from
fix/refactor-zboxcore-mobilesdk-fixes
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+710
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expose GetVersion method.
…fix/refactor-zboxcore-mobilesdk-fixes
…rders and blobbers. exposed Faucet method.
yash10019coder
requested review from
peterlimg,
dabasov and
guruhubb
as code owners
October 4, 2024 02:25
…fix/refactor-zboxcore-mobilesdk-fixes
…fix/refactor-zboxcore-mobilesdk-fixes
dabasov
requested changes
Oct 14, 2024
remove: duplicate GetConfig in zcncore/get_data.go
refactor: GetStorageConfig to GetConfig
Jayashsatolia403
requested changes
Nov 2, 2024
…om zboxcore. refactor: remove separate methods for staking, unstaking and collect rewards from zboxcore/execute_transactions.go
expose: GetValidatorByID.
fix: add wallet mode for kms in mobilesdk.
Jayashsatolia403
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Jayashsatolia403
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
expose GetBlobbers method.
expose GetStorageConfig method.
expose GetVersion method.
expose ConvertToValue method.
exposed staking, unstaking and collect reward methods for miners, sharders and blobbers.
exposed Faucet method.
expose GetStakePoolUserInfo.
Fix
Setup auth
fix: fixed restriction setup
fix: fixed bugs
fix: fixed bugs
fix: fixed bugs
fix: fixed bugs
fix: fixed bugs
Fix
add docs for expose GetStakePoolUserInfo method.
expose VerifyTransaction method.
expose GetTransactions method in gosdk.
expose GetFeesTable method.
fix: error initializing sdk.
fix: GetTransactions method.
fix: init_node.go network initialization.
fix: sdk not initialized error for zboxcore methods.
refactor: add provider type field in StakePoolDelegatePoolInfo.
debug: mobile build flagsin mobilesdk/sdk.go.
debug: playground script.
refactor: combined blobber and miner/sharder user stake pool info.
go mod tidy
fix: add provider id in StakePoolDelegatePoolInfo.
expose: GetConfig method.
remove faucet method from mobilesdk.
fix: InitStorageSDK method error.
refactor: add custom fees to all of the mobilesdk methods for staking, unstaking and claim rewards.
refactor: add fees in sendZCN.
fix: wasmsdk send token to pass fee parameter.
expose: client.Sign
expose: sdk.GetClientEncryptedPublicKey
expose: CreateThumbnail method.
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):