Repair allocation test #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewartie4
reviewed
Nov 30, 2021
| @@ -1499,3 +1499,7 @@ func registerAndCreateAllocation(t *testing.T, configPath, wallet string) (strin | |||
|
|
|||
| return allocationID, walletModel | |||
| } | |||
|
|
|||
| func registerAndCreateAllocation(t *testing.T, configPath, wallet string) (string, *climodel.Wallet) { | |||
There was a problem hiding this comment.
minor: we already have multiple utility functions that performs this functionality - can we use these instead of adding a new function?
|
@moldis what's the status of this PR? |
|
@moldis doing some tidy up - should this PR be closed? |
stewartie4
reviewed
Sep 15, 2022
There was a problem hiding this comment.
closing as superseded by #411
If anyone objects they can re-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will work only after these 2 branches merged
0chain/zboxcli#135
https://github.com/0chain/gosdk/runs/4368402836?check_suite_focus=true
Related to #117