Typo fixed in: Update README.md #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I suggest two grammatical changes for this text: First one: "it's" vs. "its": "Each peer/node on the network is identified via it's ENR..." → "Each peer/node on the network is identified via its ENR..." Explanation: "It's" is a contraction of "it is," whereas "its" is the possessive form. Second one: "PING/PONG's": "through regular PING/PONG's with discovered nodes." → "through regular PING/PONGs with discovered nodes." Explanation: "PING/PONGs" should not have an apostrophe since it refers to a plural form, not possession. Thanks and a happy new year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I suggest two grammatical changes for this text:
First one: "it's" vs. "its":
"Each peer/node on the network is identified via it's ENR..." → "Each peer/node on the network is identified via its ENR..." Explanation: "It's" is a contraction of "it is," whereas "its" is the possessive form.
Second one: "PING/PONG's":
"through regular PING/PONG's with discovered nodes." → "through regular PING/PONGs with discovered nodes." Explanation: "PING/PONGs" should not have an apostrophe since it refers to a plural form, not possession.
Thanks and a happy new year.
This change is