guard against missing schema or errors in codegen (#89)

0no-co · Jun 27, 2023 · b7c24f6 · b7c24f6
1 parent 313cb3b
commit b7c24f6
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/.changeset/quick-tips-promise.md b/.changeset/quick-tips-promise.md
@@ -0,0 +1,5 @@
+---
+'@0no-co/graphqlsp': patch
+---
+
+Guard against no schema or errored codegen attempts
diff --git a/packages/graphqlsp/src/diagnostics.ts b/packages/graphqlsp/src/diagnostics.ts
@@ -309,7 +309,9 @@ export function getGraphQLDiagnostics(
         texts.join('\n'),
         scalars,
         baseTypesPath
-      ).then(() => {
+      ).then(({ success }) => {
+        if (!success) return undefined;
+
         source = getSource(info, filename);
         if (!source) return undefined;
 

diff --git a/packages/graphqlsp/src/graphql/generateTypes.ts b/packages/graphqlsp/src/graphql/generateTypes.ts
@@ -59,9 +59,9 @@ export const generateTypedDocumentNodes = async (
   doc: string,
   scalars: Record<string, unknown>,
   baseTypesPath: string
-) => {
+): Promise<{ success: boolean }> => {
   try {
-    if (!schema) return;
+    if (!schema) return { success: false };
 
     const parts = outputFile.split('/');
     parts.pop();
@@ -106,5 +106,9 @@ export const generateTypedDocumentNodes = async (
     fs.writeFile(path.join(outputFile), output, 'utf8', err => {
       console.error(err);
     });
-  } catch (e) {}
+
+    return { success: true };
+  } catch (e) {
+    return { success: false };
+  }
 };