fix nested persisted operation resolution

0no-co · Jun 7, 2024 · e68cd45 · e68cd45
1 parent adfa3ce
commit e68cd45
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/.changeset/fifty-mangos-doubt.md b/.changeset/fifty-mangos-doubt.md
@@ -0,0 +1,5 @@
+---
+'@0no-co/graphqlsp': patch
+---
+
+Fix nested fragment resolution during persisted traversal
diff --git a/packages/graphqlsp/src/persisted.ts b/packages/graphqlsp/src/persisted.ts
@@ -166,16 +166,22 @@ export const generateHashForDocument = (
     foundFilename,
     info
   ).combinedText;
+
   const parsed = parse(text);
-  const spreads = new Set();
+  const spreads = new Set<string>();
   visit(parsed, {
     FragmentSpread: node => {
       spreads.add(node.name.value);
     },
   });
 
   let resolvedText = text;
-  [...spreads].forEach(spreadName => {
+  const visited = new Set();
+  const traversedSpreads = [...spreads];
+
+  let spreadName: string | undefined;
+  while ((spreadName = traversedSpreads.shift())) {
+    visited.add(spreadName);
     const fragmentDefinition = fragments.find(x => x.name.value === spreadName);
     if (!fragmentDefinition) {
       info.project.projectService.logger.info(
@@ -184,8 +190,15 @@ export const generateHashForDocument = (
       return;
     }
 
+    visit(fragmentDefinition, {
+      FragmentSpread: node => {
+        if (!visited.has(node.name.value))
+          traversedSpreads.push(node.name.value);
+      },
+    });
+
     resolvedText = `${resolvedText}\n\n${print(fragmentDefinition)}`;
-  });
+  }
 
   return createHash('sha256').update(resolvedText).digest('hex');
 };