feat: support first argument in graphql.persisted #287
Conversation
🦋 Changeset detectedLatest commit: 45d481a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if ( | ||
| !ts.isIdentifier(callExpression.arguments[1]) && | ||
| !ts.isCallExpression(callExpression.arguments[1]) | ||
| ) { | ||
| return { | ||
| category: ts.DiagnosticCategory.Warning, | ||
| code: MISSING_PERSISTED_TYPE_ARG, | ||
| file: source, | ||
| messageText: | ||
| 'Provided argument should be an identifier or invocation of "graphql" in the shape of graphql.persisted(hash, document).', | ||
| start, | ||
| length, | ||
| }; | ||
| } |
There was a problem hiding this comment.
This seems a bit optimistic, so we may have to leave a todo here to check this later?
There was a problem hiding this comment.
Realistically it can only be graphql.persisted(hash, document || graphql()) no?
There was a problem hiding this comment.
Hard to tell, I'm mostly afraid of indirection, e.g. re-exports with reassignments, etc, messing with later checks. So, just realised this doesn't really have much to do with the check here, but with the extraction in the other place 🤔
Co-authored-by: Phil Pluckthun <[email protected]>
We have a follow up planned where we leverage the typeChecker like https://github.com/0no-co/gql.tada/blob/main/packages/cli-utils/src/commands/cache.ts#L70-L91 to adjust the routing of
ts.identifierandts.typeQueryto the document.