feat(diagnostics): validate up to date hash #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c33a6b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Apr 22, 2024
kitten
reviewed
Apr 22, 2024
| @@ -247,6 +250,26 @@ export function getGraphQLDiagnostics( | |||
| }; | |||
| } | |||
|
|
|||
| const hash = callExpression.arguments[0].getText().slice(1, -1); | |||
| if (hash.startsWith('sha256:')) { | |||
| const upToDateHash = `sha256:${generateHashForDocument( | |||
There was a problem hiding this comment.
This may compose into sha256:undefined which then likely always issues the warning instead of bailing out
There was a problem hiding this comment.
we have basically evaluated all the pre-conditions for this not to happen though
Co-authored-by: Phil Pluckthun <[email protected]>
…GraphQLSP into add-validation-for-up-to-date-po
kitten
approved these changes
Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During diagnostics when we see a prefix of
sha256we can assume that we generated the hash, this means we can verify whether it's up to date. This adds a warn diagnostic for persisted-operations and warns you when the hash is up to date with the document.