Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduplicate fragments when generating persisted document hash #342

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

felamaslen
Copy link
Contributor

resolves #341

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: ef3f3c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@0no-co/graphqlsp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felamaslen
Copy link
Contributor Author

felamaslen commented Jul 5, 2024

I'm not sure if you'd count this as a breaking change. It is really a bug fix, but it would mean that certain documents which previously passed npx gql-tada check will no longer pass.

@JoviDeCroock
Copy link
Member

JoviDeCroock commented Jul 5, 2024

Would be good to add a changeset and double check the implementation of the CLI whether the ordering could be different. It's a patch

@JoviDeCroock
Copy link
Member

The ClI impl feels a bit simpler with the seen set but comes down to the same thing so good to go https://github.com/0no-co/gql.tada/blob/main/packages/cli-utils/src/commands/generate-persisted/thread.ts

@JoviDeCroock JoviDeCroock merged commit 84e53e4 into 0no-co:main Jul 5, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
@felamaslen
Copy link
Contributor Author

Yep was just about to say the same thing. Ordering is the same in each case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source of persisted operation hash contains duplicate fragments
2 participants