avoid giving diagnostics for stuff falling out of the node-range #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #72
This avoids us polluting the LSP with diagnostics that go outside of the AST Node Range. An ideal solution here would be to indicate these on the
FragmentDefinition
itself, or TypeScript providing a way to tell us about a nested error.This PR partially resolves the problem but introduces a new one where if folks add identifiers to the start of their document that we will convey the wrong information, however this is currently also present... After experimenting 😅
Ideally during
resolve
we will start returningThis will allow us to translate and combine diagnostics effectively