Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update styles to WinUI 2 #808

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

soumyamahunt
Copy link
Contributor

@soumyamahunt soumyamahunt commented Mar 19, 2021

This PR fixes conflicts in #806. With WCT moving to WinUI 2.5 it is essential Notepads should update to WinUI 2.5 to maintain compatibility. Most of the designs have been updated to implement rounded corners etc.

PR Type

What kind of change does this PR introduce?

  • Feature

@soumyamahunt
Copy link
Contributor Author

@Jasonstein there is a bug I noticed in WinUI2 which have been reported here we can either wait for it to be fixed or update our styles for different behavior. Most of the work is done, I just have following queries to finish the transition:

  1. Do you still want to host parts of WCT in project itself, do you want to remove those parts??
  2. Do you want to move from Notepads' custom SetsView to WinUI's TabView or keep things as it is??
  3. Have a look on different control styles and let me know if you want me to change anything.

@0x7c13
Copy link
Owner

0x7c13 commented Mar 20, 2021

@Jasonstein there is a bug I noticed in WinUI2 which have been reported here we can either wait for it to be fixed or update our styles for different behavior. Most of the work is done, I just have following queries to finish the transition:

  1. Do you still want to host parts of WCT in project itself, do you want to remove those parts??
  2. Do you want to move from Notepads' custom SetsView to WinUI's TabView or keep things as it is??
  3. Have a look on different control styles and let me know if you want me to change anything.
  1. As long as they matches the design.
  2. No, I don't like the look and feel of their approach. At least it does not fit well in Notepads.
  3. I like the current approach as it is.

@soumyamahunt
Copy link
Contributor Author

@Jasonstein here are comparison some of the design changes:

Before

After

oU0sLUD0Nq tQvSTdiRsP
PnsvJ8oWKF Jiokb3khEy
qkzsJosKjF C5cvNvnY3u
mEyem02dlP p694OZ4t52
ApplicationFrameHost_xskGOPnnv2 ApplicationFrameHost_yYkkyVA7qJ
ApplicationFrameHost_LYWeFinaI0 ApplicationFrameHost_GW9C6Vualh
ApplicationFrameHost_gild41SXDO ApplicationFrameHost_E0sApoJBdw
ApplicationFrameHost_SmG62HtbVw ApplicationFrameHost_STOcjyX2lo
ApplicationFrameHost_67FeZFAfiM ApplicationFrameHost_psCMUv9RUK
ApplicationFrameHost_UTTnLq9P2W ApplicationFrameHost_AMr23X5bnc
ApplicationFrameHost_gShsUSNIc0 ApplicationFrameHost_bLTEbAqUkU
SrdodhwO3n hwXaoGPMdi
ApplicationFrameHost_LimsqFytIU ApplicationFrameHost_4Usb5Fft1q

@soumyamahunt soumyamahunt marked this pull request as ready for review March 21, 2021 07:07
@0x7c13
Copy link
Owner

0x7c13 commented Mar 21, 2021

Overall looks good to me. There is only one thing that makes me sad: most of the current Windows apps are still using rectangle design and also the app Window itself is a rectangle and it does not fit well with the overall rounded corners of the controls. Maybe we should do it later once Windows is fully embracing the rounded corner design and I believe it should be coming real soon. Is there any way to keep all your existing work as it is but set the corner radius to 0 and makes it look just like before? And when time is right, we can set it to rounded corner if that's doable.

@soumyamahunt
Copy link
Contributor Author

Overall looks good to me. There is only one thing that makes me sad: most of the current Windows apps are still using rectangle design and also the app Window itself is a rectangle and it does not fit well with the overall rounded corners of the controls. Maybe we should do it later once Windows is fully embracing the rounded corner design and I believe it should be coming real soon. Is there any way to keep all your existing work as it is but set the corner radius to 0 and makes it look just like before? And when time is right, we can set it to rounded corner if that's doable.

I have disabled rounded corners for now and added notes to reenable them once SunValley becomes GA.

Also, are you satisfied with the WinUI's Colorpicker or do you want to use the Community Toolkit's Colorpicker??

Regarding the WinUI's TabView, we can customize the look and feel similar to Notepads while not maintaining the code. Do you still want to use current SetsView??

@soumyamahunt soumyamahunt changed the title Update designs to WinUI 2 feat: Update designs to WinUI 2 Mar 29, 2021
@soumyamahunt soumyamahunt changed the title feat: Update designs to WinUI 2 feat: Updated designs to WinUI 2 Mar 29, 2021
@soumyamahunt soumyamahunt changed the title feat: Updated designs to WinUI 2 feat: updated styles to WinUI 2 Apr 18, 2021
@soumyamahunt soumyamahunt changed the title feat: updated styles to WinUI 2 feat: update styles to WinUI 2 Apr 18, 2021
@soumyamahunt soumyamahunt marked this pull request as draft April 18, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants